Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: rpc: openthread: dynamic allocation for CLI commands #19228

Closed
wants to merge 2 commits into from
Closed

net: rpc: openthread: dynamic allocation for CLI commands #19228

wants to merge 2 commits into from

Conversation

konradderda
Copy link
Contributor

No description provided.

@konradderda konradderda requested review from a team as code owners December 3, 2024 15:50
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Dec 3, 2024
@konradderda
nrf_rpc: add function for decoding string without copying
2c9bdcf 
This commit adds new helper function nrf_rpc_decode_str_ptr_and_len()
that decodes CBOR string without copying it to a buffer. It allows to
get string length before buffer allocation.

Signed-off-by: Konrad Derda <[email protected]>
@konradderda
net: openthread: rpc: dynamically allocate memory for CLI line
e76b1ef 
CLI commands may require large buffer for command strings. This commit
introduces usage of dynamic allocation to avoid usage of huge static
buffer.

Signed-off-by: Konrad Derda <[email protected]>
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Dec 3, 2024 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 2

Inputs:

Sources:

sdk-nrf: PR head: e76b1effe45ba2b32c25e41acaf53fd21fa4c300

more details

sdk-nrf:

PR head: e76b1effe45ba2b32c25e41acaf53fd21fa4c300
merge base: 09228a59365ab09daab2c6050044d6c9cf065ea1
target head (main): 407ea0cbebd53bfc5c3565a582efa2039535d455
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (3) 
include
│  ├── nrf_rpc
│  │  │ nrf_rpc_serialize.h
subsys
│  ├── net
│  │  ├── openthread
│  │  │  ├── rpc
│  │  │  │  ├── server
│  │  │  │  │  │ ot_rpc_cli.c
│  ├── nrf_rpc
│  │  │ nrf_rpc_serialize.c

Outputs:

Toolchain

Version: b77d8c1312
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:b77d8c1312_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ❌ Build twister
    • sdk-nrf test count: 1036
  • ❌ Integration tests
    • ❌ test_ble_nrf_config
    • ❌ test-fw-nrfconnect-ble_samples
    • ❌ test-fw-nrfconnect-rpc
    • ❌ test-fw-nrfconnect-rs
    • ❌ test-fw-nrfconnect-fem
    • ❌ test-fw-nrfconnect-thread
    • ❌ test-sdk-dfu
    • ❌ test-fw-nrfconnect-ps
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@gmarull gmarull closed this Dec 5, 2024
@gmarull gmarull deleted the rpc_cli_malloc branch December 5, 2024 07:55
@gmarull
Copy link
Member

gmarull commented Dec 5, 2024

please use forks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canisLupus1313 canisLupus1313 canisLupus1313 approved these changes

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@alxelax alxelax alxelax approved these changes

Assignees
No one assigned
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@konradderda @NordicBuilder @gmarull @alxelax @Damian-Nordic @canisLupus1313