Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: west_commands: create_board: fix openocd for nrf52 #19242

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

gmarull
Copy link
Member

@gmarull gmarull commented Dec 4, 2024

Since custom boards may not contain the soc name as part of the board name, automatic guess does not work.

Since custom boards may not contain the soc name as part of the
board name, automatic guess does not work.

Signed-off-by: Gerard Marull-Paretas <[email protected]>
@gmarull gmarull added the bug Something isn't working label Dec 4, 2024
@gmarull gmarull added this to the 2.9.0 milestone Dec 4, 2024
@gmarull gmarull requested a review from kylebonnici December 4, 2024 09:27
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Dec 4, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Dec 4, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 1

Inputs:

Sources:

sdk-nrf: PR head: 9f51af13e356d77cf45e8baabe250bfa3e3c51ea

more details

sdk-nrf:

PR head: 9f51af13e356d77cf45e8baabe250bfa3e3c51ea
merge base: b7a0d83eb2aecc0525fea07d2bb1e3ac695a0839
target head (main): b7a0d83eb2aecc0525fea07d2bb1e3ac695a0839
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (1)
scripts
│  ├── west_commands
│  │  ├── create_board
│  │  │  ├── templates
│  │  │  │  ├── nrf52
│  │  │  │  │  │ board.cmake.jinja2

Outputs:

Toolchain

Version: b77d8c1312
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:b77d8c1312_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 44
  • ✅ Integration tests
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

Copy link

@kylebonnici kylebonnici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me if it compile for 52 boards with board name that does not include the SOC name

@jukkar jukkar merged commit f4e6aaf into nrfconnect:main Dec 4, 2024
19 checks passed
@gmarull gmarull deleted the genboard-openocd branch December 4, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants