samples: bluetooth: Update distance estimation for mode 3 and multi a… #19252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog-entry-required
sean-madigan
force-pushed
the
prepare_rreq_sample_for_multi_antenna_mode_3
branch
from
98ce329 to
0b19f2e
Compare
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: d405961ead610f8bf29f5d77b6769d3c8565d3c1 more detailssdk-nrf:
Github labels
List of changed files detected by CI (1)Outputs:ToolchainVersion: b77d8c1312 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
sean-madigan
force-pushed
the
prepare_rreq_sample_for_multi_antenna_mode_3
branch
from
0b19f2e to
bfb2063
Compare
| mode_1_data[context->mode_1_data_index].toa_tod_initiator = | ||
| peer_step_data->toa_tod_initiator; | ||
| } | ||
| } else if (local_step->mode == BT_HCI_OP_LE_CS_MAIN_MODE_3) { |
There was a problem hiding this comment.
would probably be a bit more logical to add this later (when the sample actually generates mode 3 steps)
There was a problem hiding this comment.
don't see a down side to merging this now
olivier-le-sage
approved these changes
Dec 4, 2024
| @@ -21,7 +21,8 @@ LOG_MODULE_DECLARE(app_main, LOG_LEVEL_INF); | |||
| #define SPEED_OF_LIGHT_M_PER_S (299792458.0f) | |||
| #define SPEED_OF_LIGHT_NM_PER_S (SPEED_OF_LIGHT_M_PER_S / 1000000000.0f) | |||
| #define PI 3.14159265358979323846f | |||
| #define MAX_NUM_SAMPLES 256 | |||
| #define MAX_NUM_RTT_SAMPLES 256 | |||
| #define MAX_NUM_IQ_SAMPLES 256 * CONFIG_BT_RAS_MAX_ANTENNA_PATHS | |||
There was a problem hiding this comment.
it's not really related to this PR but I suppose another improvement would be to process the tone extension slots
…ntenna Mode 3 is a combination of modes 1 and 2, so extract out some of the common logic and use this for mode 3. Adjust array sizes and indexes so they can be used for multi antenna. Signed-off-by: Sean Madigan <[email protected]>
sean-madigan
force-pushed
the
prepare_rreq_sample_for_multi_antenna_mode_3
branch
from
bfb2063 to
d405961
Compare
weeTike
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ntenna
Mode 3 is a combination of modes 1 and 2, so extract out some of the common logic and use this for mode 3.
Adjust array sizes and indexes so they can be used for multi antenna.