-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ZMS as default storage subsystem for Soc family that has MRAM #19286
Add ZMS as default storage subsystem for Soc family that has MRAM #19286
Conversation
Some bluetooth samples are still selecting NVS for boards that have mram technologies instead of ZMS. Fix this by adding the missing CONFIG dependency Signed-off-by: Riadh Ghaddab <[email protected]>
1955514
to
fe7ca22
Compare
@@ -37,7 +37,7 @@ config SETTINGS | |||
default y | |||
|
|||
config ZMS | |||
default y if !(SOC_FLASH_NRF_RRAM || SOC_FLASH_NRF_MRAM) | |||
default y if (SOC_FLASH_NRF_RRAM || SOC_FLASH_NRF_MRAM) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pdunaj Why was this set to the opposite ?
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publish GitHub Action. |
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 0cd24bd676612aa7f6a2f2a39af6d97a8563ac9b more detailssdk-nrf:
Github labels
List of changed files detected by CI (7)
Outputs:ToolchainVersion: b77d8c1312 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
Adds the warning in the CMakeLists.txt when NVS is selected for the nRF54H SoC family as well Signed-off-by: Riadh Ghaddab <[email protected]>
fe7ca22
to
0cd24bd
Compare
This storage change wasn't needed in the Locator Tag sample as the nRF54H is not supported as part of this sample. The sample Kconfig change implies now that this sample supports MRAM targets |
For some samples ZMS is still not selected as the default storage subsystem when the SoC family has an MRAM flash