-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logging: rpc: get rid of global output buffer #19325
Conversation
1. Remove the global log output and output buffer from the nRF RPC logging backend. 2. Add helper functions to format a log message into a buffer, and align the backend to use these helpers. Thanks to these changes, it is possible to format log messages from multiple threads, which will be utilized in an upcoming PR. Additionally, even a large message can now be sent in a single RPC event. Signed-off-by: Damian Krolik <[email protected]>
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 32ad6e7014281394d83e87aa79ef547eb4fe5427 more detailssdk-nrf:
Github labels
List of changed files detected by CI (2)
Outputs:ToolchainVersion: b77d8c1312 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publish GitHub Action. |
@nordicjm I could use your review :) |
Thanks to these changes, it is possible to format log messages from multiple threads, which will be utilized in an upcoming PR. Additionally, even a large message can now be sent in a single RPC event.