Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snippets: nrf70-wifi: Remove heap size override #20101

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

D-Triveni
Copy link
Contributor

@D-Triveni D-Triveni commented Jan 28, 2025

Remove the heap size override as it is
no longer needed due to sufficient RAM availability.

@D-Triveni D-Triveni requested a review from a team as a code owner January 28, 2025 12:29
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 28, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 28, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 2

Inputs:

Sources:

sdk-nrf: PR head: ad80496fea2e2b2d9cae7f481b82dc62b60442a3

more details

sdk-nrf:

PR head: ad80496fea2e2b2d9cae7f481b82dc62b60442a3
merge base: 8f6412f03f66ab97bda89ecb185b51393206fdf0
target head (main): 8f6412f03f66ab97bda89ecb185b51393206fdf0
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (1)
snippets
│  ├── nrf70-wifi
│  │  │ nrf54h20_cpuapp.conf

Outputs:

Toolchain

Version: 342151af73
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:342151af73_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 38
  • ✅ Integration tests
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

Copy link
Contributor

@krish2718 krish2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not redundant it was necessary to avoid RAM overflows as default HEAP was too high, if that is not the case anymore we can remove it but with appropriate commit log.

snippets/nrf70-wifi/nrf54h20_cpuapp.conf Outdated Show resolved Hide resolved
Remove the heap size override as it is no longer
needed due to sufficient RAM availability.

Signed-off-by: Triveni Danda <[email protected]>
@D-Triveni D-Triveni force-pushed the remove_heap_mem_config_54h branch from 1559d0d to ad80496 Compare January 29, 2025 06:38
@D-Triveni D-Triveni changed the title snippets: nrf70-wifi: Remove redundant config snippets: nrf70-wifi: Remove heap size override Jan 29, 2025
@krish2718 krish2718 changed the title snippets: nrf70-wifi: Remove heap size override snippets: nrf70-wifi: Remove heap size override Jan 29, 2025
@rlubos rlubos merged commit f76220a into nrfconnect:main Feb 3, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants