Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samples: simplify sysbuild kconfig #659

Merged
merged 2 commits into from
Dec 16, 2024
Merged

samples: simplify sysbuild kconfig #659

merged 2 commits into from
Dec 16, 2024

Conversation

ktaborowski
Copy link
Contributor

@ktaborowski ktaborowski commented Dec 10, 2024 •
edited
Loading

Replace baord symbols with soc kconfigs

CI parameters

Github_actions:
  #(branch, hash, pull/XXX/head)
  NRF_revision: main

  # Do not change after creating PR
  Create_NRF_PR: false
Jenkins:
  test-sdk-sidewalk: master

Description

JIRA ticket:

Self review

  • There is no commented code.
  • There are no TODO/FIXME comments without associated issue ticket.
  • Commits are properly organized.
  • Change has been tested.
  • Tests were updated (if applicable).

@github-actions github-actions bot added the source PR changing src files label Dec 10, 2024
@ktaborowski ktaborowski mentioned this pull request Dec 10, 2024
Merged
5 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 10, 2024 •
edited
Loading

Sample diff used total

Memory usage did not change for any of the samples.

nordicjm
nordicjm requested changes Dec 11, 2024
View reviewed changes
@ktaborowski
samples: simplify sysbuild kconfig
e8af66e 
Replace board symbols with soc kconfigs

Signed-off-by: Krzysztof Taborowski <[email protected]>
@ktaborowski ktaborowski requested a review from nordicjm December 13, 2024 08:06
@ktaborowski
tests: simplify sysbuild configs
8ca4cf4 
Replace board with soc

Signed-off-by: Krzysztof Taborowski <[email protected]>
@github-actions github-actions bot added the tests label Dec 13, 2024
@ktaborowski ktaborowski merged commit 2ad48d4 into nrfconnect:main Dec 16, 2024
57 checks passed
@ktaborowski ktaborowski deleted the kconfig_improve branch December 16, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nordicjm nordicjm nordicjm approved these changes

@RobertGalatNordic RobertGalatNordic RobertGalatNordic approved these changes

Assignees
No one assigned
Labels
source PR changing src files tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ktaborowski @nordicjm @RobertGalatNordic