Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ble: Remove CONFIG_BT_BUF_ACL_RX_COUNT #664

Merged
merged 1 commit into from
Dec 20, 2024
Merged

ble: Remove CONFIG_BT_BUF_ACL_RX_COUNT #664

merged 1 commit into from
Dec 20, 2024

Conversation

PavelVPV
Copy link
Contributor

@PavelVPV PavelVPV commented Dec 12, 2024 •
edited by ktaborowski
Loading

CONFIG_BT_BUF_ACL_RX_COUNT has been deprecated in
zephyrproject-rtos/zephyr#81747 CONFIG_BT_BUF_ACL_RX_COUNT_EXTRA has been introduced to replace it.

CI parameters

Github_actions:
  #(branch, hash, pull/XXX/head)
  NRF_revision: pull/19412/head

  # Do not change after creating PR
  Create_NRF_PR: false
Jenkins:
  test-sdk-sidewalk: master

Description

JIRA ticket:

Self review

  • There is no commented code.
  • There are no TODO/FIXME comments without associated issue ticket.
  • Commits are properly organized.
  • Change has been tested.
  • Tests were updated (if applicable).

@PavelVPV
ble: Remove CONFIG_BT_BUF_ACL_RX_COUNT
79a7772 
CONFIG_BT_BUF_ACL_RX_COUNT has been deprecated in
zephyrproject-rtos/zephyr#81747
CONFIG_BT_BUF_ACL_RX_COUNT_EXTRA has been introduced to replace it.

Signed-off-by: Pavel Vasilyev <[email protected]>
@github-actions github-actions bot added the source PR changing src files label Dec 12, 2024
@PavelVPV
Copy link
Contributor Author

Needed for nrfconnect/sdk-nrf#19412

@NordicBuilder NordicBuilder mentioned this pull request Dec 12, 2024
Merged
ktaborowski
ktaborowski approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@ktaborowski ktaborowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ktaborowski
Copy link
Contributor

Updated description an rerun github action test - previously fail because was build with main skd-nrf

@github-actions GitHub Actions
Copy link

Sample diff used total
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.demo.ble_only RAM 4 B 105.83 KB 0 B
ROM -64 B 328.52 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.dut RAM 4 B 144.62 KB 0 B
ROM -72 B 472.96 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.dut.ble_only RAM 4 B 129.52 KB 0 B
ROM -72 B 394.67 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.dut.no_secure RAM 4 B 144.62 KB 0 B
ROM -72 B 470.26 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.hello RAM 4 B 122.32 KB 0 B
ROM -68 B 421.57 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.hello.ble_only RAM 4 B 95.87 KB 0 B
ROM -64 B 326.82 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.hello.ble_only.release RAM 4 B 91.24 KB 0 B
ROM -76 B 256.32 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.hello.release RAM 4 B 106.29 KB 0 B
ROM -76 B 332.2 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.demo RAM 4 B 121.65 KB 0 B
ROM 96 B 456.29 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.demo.ble_only RAM 4 B 106.6 KB 0 B
ROM 96 B 378.53 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.dut RAM 4 B 145.4 KB 0 B
ROM 88 B 522.74 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.dut.ble_only RAM 4 B 130.3 KB 0 B
ROM 88 B 444.45 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.dut.no_secure RAM 4 B 145.39 KB 0 B
ROM 88 B 515.05 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.hello RAM 4 B 123.1 KB 0 B
ROM 92 B 471.57 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.hello.ble_only RAM 4 B 96.65 KB 0 B
ROM 96 B 376.83 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.hello.ble_only.release RAM 4 B 92.02 KB 0 B
ROM 84 B 305.39 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.hello.release RAM 4 B 107.07 KB 0 B
ROM 84 B 381.27 KB 0 B
thingy53/nrf5340/cpuapp:sample.sidewalk.demo.ble_only RAM 292 B 109.72 KB 0 B
ROM 84 B 357.84 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.demo RAM 4 B 123.75 KB 0 B
ROM 60 B 478.89 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.demo.ble_only RAM 4 B 108.4 KB 0 B
ROM 60 B 396.4 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.dut RAM 4 B 147.39 KB 0 B
ROM 56 B 544.85 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.dut.ble_only RAM 4 B 131.99 KB 0 B
ROM 56 B 461.74 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.dut.no_secure RAM 4 B 147.37 KB 0 B
ROM 56 B 536.29 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.hello RAM 4 B 124.97 KB 0 B
ROM 64 B 494.19 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.hello.ble_only RAM 4 B 98.23 KB 0 B
ROM 60 B 394.73 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.hello.ble_only.release RAM 4 B 93.42 KB 0 B
ROM 52 B 325.35 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.hello.release RAM 4 B 108.77 KB 0 B
ROM 52 B 404.32 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.demo RAM 292 B 115.16 KB 0 B
ROM 84 B 401.82 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.demo.ble_only RAM 292 B 99.96 KB 0 B
ROM 84 B 318.22 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.dut RAM 292 B 138.92 KB 0 B
ROM 76 B 468.51 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.dut.ble_only RAM 292 B 123.68 KB 0 B
ROM 76 B 384.44 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.dut.no_secure RAM 292 B 138.91 KB 0 B
ROM 76 B 461.08 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.hello RAM 292 B 116.65 KB 0 B
ROM 84 B 417.38 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.hello.ble_only RAM 292 B 90.05 KB 0 B
ROM 84 B 316.78 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.hello.ble_only.release RAM 292 B 85.4 KB 0 B
ROM 96 B 245.11 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.hello.release RAM 292 B 100.6 KB 0 B
ROM 96 B 324.88 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.demo RAM 4 B 121.65 KB 0 B
ROM 92 B 456.26 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.demo.ble_only RAM 4 B 106.6 KB 0 B
ROM 92 B 378.5 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.dut RAM 4 B 145.4 KB 0 B
ROM 84 B 522.7 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.dut.ble_only RAM 4 B 130.3 KB 0 B
ROM 84 B 444.42 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.dut.no_secure RAM 4 B 145.39 KB 0 B
ROM 84 B 515.02 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.hello RAM 4 B 123.1 KB 0 B
ROM 96 B 471.54 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.hello.ble_only RAM 4 B 96.65 KB 0 B
ROM 92 B 376.8 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.hello.ble_only.release RAM 4 B 92.02 KB 0 B
ROM 84 B 305.36 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.hello.release RAM 4 B 107.07 KB 0 B
ROM 84 B 381.24 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.demo RAM 4 B 120.87 KB 0 B
ROM -64 B 406.26 KB 0 B

@ktaborowski ktaborowski added the from-nrf align sidewalk with ncs label Dec 16, 2024
@PavelVPV
Copy link
Contributor Author

@ktaborowski , can this be merged now? sdk-zephyr PR was merged.

@ktaborowski ktaborowski merged commit f274ce8 into nrfconnect:main Dec 20, 2024
57 checks passed
@RobertGalatNordic
Copy link
Collaborator

The NRF PR is still not ready! This change need to be reverted, and reintroduced once the NRF pr mentioned in comment is ready for merging.

@RobertGalatNordic RobertGalatNordic mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktaborowski ktaborowski ktaborowski approved these changes

Assignees
No one assigned
Labels
from-nrf align sidewalk with ncs source PR changing src files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PavelVPV @ktaborowski @RobertGalatNordic