Only for CI - Don't review #1491
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In slow networks, like Nb-IOT, when using queue mode, there might be significant delay between the time we put the packet into a transmission queue and the time we actually start transmitting. This might cause QUEUE_RX_OFF state to be triggered earlier than expected. Remedy the issue by updating the timestamp on the moment where packet is accepted by zsock_send(). Signed-off-by: Seppo Takalo <[email protected]> (cherry picked from commit 0d650ff)
Allow engine to give hints about ongoing CoAP transmissions. This information can be used to control various power saving modes for network interfaces. For example cellular networks might support release assist indicator. Signed-off-by: Seppo Takalo <[email protected]> (cherry picked from commit 6161fbd)
Deprecate lwm2m_set_u64() and lwm2m_get_u64 as only LWM2M_RES_TYPE_S64 exist. Unsigned variant is not defined. Technically these might have worked OK, but it is undefined what happens to large unsigned values when those are converted to various payload formats (like CBOR) that might decode numbers differently depending of their signedness. Signed-off-by: Seppo Takalo <[email protected]> (cherry picked from commit 071cad2)
…well Refactored the socket state indication into its own function that checks the state of TX queues as well as number of pending CoAP responses. Check the state after receiving a packet, as it might have been a last Ack packet we have been waiting. Signed-off-by: Seppo Takalo <[email protected]> (cherry picked from commit dc6e7aa)
Add short delay before triggering registration update. This allows postponing the update from application side if needed. Signed-off-by: Juha Ylinen <[email protected]> (cherry picked from commit 85dfe3d)
…se() lwm2m_engine_pause() caused deadlock if it was called within engine thread. Remove while loop from lwm2m_engine_resume(). Signed-off-by: Juha Ylinen <[email protected]> (cherry picked from commit 7c53fa8)
… qemu_x86 When running on qemu_x86, the test test_socket_state failed on stack overflow. Setting CONFIG_TEST_EXTRA_STACK_SIZE to 1024 seems to fix the issue. So add a board specific config for qemu_x86 so this test would pass. Signed-off-by: Daniel Leung <[email protected]> (cherry picked from commit 78790a8)
…ssages Adding a callback for handling lwm2m messages with prefixed paths defined by the gateway object. If CONFIG_LWM2M_GATEWAY_OBJ_SUPPORT is set, each path is checked for the prefix stored in the object instances of the gateway object 25. If prefixes match the msg is passed to the gw_msg_cb. Signed-off-by: Simon Walz <[email protected]> (cherry picked from commit 38aa4d5)
Add change scope to run test suite for PMIC samples Signed-off-by: Vladislav Litvinov <[email protected]>
The help text uses the capital case as its an acronym, but passing capital case fails. Also extend that to others as well. Signed-off-by: Chaitanya Tata <[email protected]> (cherry picked from commit 9e6542b)
This was missed in earlier that tried to fix all string comparisons to use case insensitive comparison. Signed-off-by: Chaitanya Tata <[email protected]> (cherry picked from commit 2ce295b)
The length should be 3 for WMM not 4. Signed-off-by: Chaitanya Tata <[email protected]> (cherry picked from commit dc9d5d9)
For starting an AP mode, channel is mandatory, so, fix the arguments and the help text. Upstream PR: zephyrproject-rtos/zephyr#67694 Signed-off-by: Chaitanya Tata <[email protected]>
For none and WPA-PSK MFP isn't applicable, it was only introduced in WPA2-PSK (RSN) and later. Upstream PR: zephyrproject-rtos/zephyr#67694 Signed-off-by: Chaitanya Tata <[email protected]>
These can be used for channel validation outside the utils. Upstream PR: zephyrproject-rtos/zephyr#67694 Signed-off-by: Chaitanya Tata <[email protected]>
Validate the channel for both STA and AP modes. Upstream PR: zephyrproject-rtos/zephyr#67694 Signed-off-by: Chaitanya Tata <[email protected]>
The channel extraction from string directly uses the end variable with limited data type, this causes issue if an invalid channel that exceeds the data is given as an input e.g., 300, which would end up as a valid channel 44. Use an intermediate variable with type that can hold all possible combinations (valid and invalid) and only after validation assign that to the end type. Upstream PR: zephyrproject-rtos/zephyr#67694 Signed-off-by: Chaitanya Tata <[email protected]>
Handy in giving feedback to the user rather than silent failure. Upstream PR: zephyrproject-rtos/zephyr#67694 Signed-off-by: Chaitanya Tata <[email protected]>
…r initialization This is a follow-up to commit ea1be7f. After the driver performs its initialization, it needs to deactivate the QSPI peripheral. Otherwise, the peripheral would unnecessarily consume power until some QSPI operation is performed (and only then it will get deactivated), what depending on the application may take a significant amount of time. Signed-off-by: Andrzej Głąbek <[email protected]> (cherry picked from commit 3f6373e)
Regular OpenThread upmerge to commit `75694d2`. Move CONFIG_OPENTHREAD_PLATFORM_KEY_REFERENCES_ENABLE from header file to Kconfig. Signed-off-by: Maciej Baczmanski <[email protected]> (cherry picked from commit c2f1ff7)
…ists. This commit introduces `kconfig_to_ot_option` to simply fye the way of adding openthread related kconfigs. Signed-off-by: Przemyslaw Bida <[email protected]> (cherry picked from commit b6d8d27)
Running TCAT with PSA crypto API causes stack overflow. Increased stack size. Signed-off-by: Maciej Baczmanski <[email protected]> (cherry picked from commit 11613e0)
Added `OT_PLATFORM_POWER_CALIBRATION` and set to always off as in Zephyr power calibration is handled by Radio Driver. Signed-off-by: Maciej Baczmanski <[email protected]> (cherry picked from commit d0283f9)
This commit implements `otPlatResetToBootloader` in two ways: - trigger reset to bootloader using boot mode retention API - trigger reset to bootloader by triggering GPIO pin (applicable for nRF52840 Dongle) Signed-off-by: Maciej Baczmanski <[email protected]> (cherry picked from commit f32e686)
This commit adds new types of keys and algorithm to crypto_psa backend of openthread. Added options: - `OT_CRYPTO_KEY_TYPE_ECDSA` - `OT_CRYPTO_KEY_ALG_ECDSA` - `OT_CRYPTO_KEY_USAGE_VERIFY_HASH` Signed-off-by: Przemyslaw Bida <[email protected]> (cherry picked from commit 0018204)
Remove two workarounds in OpenThread's PSA crypto backend that were required when Zephyr used pre-1.5 TF-M version: 1. psa_open_key() is no longer needed to reference a persistent key 2. psa_cipher_encrypt() can be used to simplify AES encryption Signed-off-by: Damian Krolik <[email protected]> (cherry picked from commit 36b7a3e)
When OpenThread application is built with CONFIG_ASSERT and CONFIG_ASSERT_NO_MSG_INFO, OT_ASSERT() prints a location that points to the otPlatAssertFail() function instead of the code that actually failed an assertion. This is confusing and CONFIG_ASSERT_NO_MSG_INFO sometimes cannot be disabled because of flash size limitations. Make otPlatAssertFail() always print the actual assert location. Signed-off-by: Damian Krolik <[email protected]> (cherry picked from commit 7b42e36)
…able Reference counting was broken when adding the enable delay. Now reverted to previous pattern. Signed-off-by: Andy Sinclair <[email protected]> (cherry picked from commit c3a54ae)
The current implementation implicitly assumes that if the device is configured to have the capability of acting as a CSL endpoint then in case a delayed reception with matching ID finishes with a timeout no action is needed. This assumption is correct when RxOnWhenIdle mode is disabled because the transition to sleep is done automatically by the driver below. However, it's wrong when RxOnWhenIdle is enabled. This commit fixes that case by adding a call to event handler that notifies the higher layer about the event and allows it to transition to RxOff if needed. Upstream PR: zephyrproject-rtos/zephyr#67774 Signed-off-by: Jędrzej Ciupis <[email protected]>
Fix missing breaks errors. Signed-off-by: Andrei Emeltchenko <[email protected]> (cherry picked from commit db1c21b)
The place where TF-M places its non-secure api header files has changed Therefore changing it for for all applications that use it. Signed-off-by: Markus Swarowsky <[email protected]> (cherry picked from commit 11175c3) Signed-off-by: Markus Swarowsky <[email protected]>
The platform_ns library is no longer build with the split build anymore so removing it. Signed-off-by: Markus Swarowsky <[email protected]> (cherry picked from commit 8b257c0) Signed-off-by: Markus Swarowsky <[email protected]>
…interface files Update source lib and include path for TF-M interface files. Signed-off-by: Joakim Andersson <[email protected]> Signed-off-by: Markus Swarowsky <[email protected]> (cherry picked from commit a14f42a) Signed-off-by: Markus Swarowsky <[email protected]>
The TFM error codes are no longer in the interface headers. All TF-M functions return PSA status codes, so use this here as well. Signed-off-by: Joakim Andersson <[email protected]> Signed-off-by: Markus Swarowsky <[email protected]> (cherry picked from commit d931dde) Signed-off-by: Markus Swarowsky <[email protected]>
…nstall path Update install path of tfm_ioctl_api.h, remove include of tfm_api.h Signed-off-by: Joakim Andersson <[email protected]> Signed-off-by: Markus Swarowsky <[email protected]> (cherry picked from commit f5eecd5) Signed-off-by: Markus Swarowsky <[email protected]>
psa_crypto_driver_wrappers.c got changed to psa_crypto_driver_wrappers_no_static.c Signed-off-by: Markus Swarowsky <[email protected]> (cherry picked from commit fbee1c6) Signed-off-by: Markus Swarowsky <[email protected]>
MbedTLS 3.5.0 requires a implementation of mbedtls_ms_time giving a time in ms for TLS 1.3 Therefor adding an alternative implementation using zephyrs k_uptime_get Signed-off-by: Markus Swarowsky <[email protected]> (cherry picked from commit dc76138) Signed-off-by: Markus Swarowsky <[email protected]>
Use TF-M PSA API headers when compiling with TF-M enabled. Fixes: #43249 Signed-off-by: Joakim Andersson <[email protected]> Signed-off-by: Markus Swarowsky <[email protected]> (cherry picked from commit 3398c98) Signed-off-by: Markus Swarowsky <[email protected]>
…s to tfm_config The target tfm_partition_defs got removed and tfm_config gets used now so updating it Signed-off-by: Markus Swarowsky <[email protected]> (cherry picked from commit e8eeecd) Signed-off-by: Markus Swarowsky <[email protected]>
…c_nrf platform. Add build of the NS application in the zephyr defined out-of-tree board support for the nordic_nrf platform. Signed-off-by: Joakim Andersson <[email protected]> Signed-off-by: Markus Swarowsky <[email protected]> (cherry picked from commit 6c92749) Signed-off-by: Markus Swarowsky <[email protected]>
… NS build folder TF-M no longer builds the NS app, but exports build files to api_ns folder and expects the user to build the rest themselves. Remove the option to build the NS app, and update the TFM_USE_NS_APP to look for an output hex file in the tfm_ns folder. Signed-off-by: Joakim Andersson <[email protected]> Signed-off-by: Markus Swarowsky <[email protected]> (cherry picked from commit f49cbf1) Signed-off-by: Markus Swarowsky <[email protected]>
Update the TF-M regression tests sample to build the NS app in the tf-m-tests repository as an external project. The regression tests need to provide test configurations to both TF-M an NS app. Duplicate configuration done in the spe/CMakeLists.txt to configure TF-M image for the regression tests. Signed-off-by: Joakim Andersson <[email protected]> Signed-off-by: Markus Swarowsky <[email protected]> (cherry picked from commit f48467a) Signed-off-by: Markus Swarowsky <[email protected]>
This removed the CMake code that builds the TF-M arch tests within the TF-M CMakeFile. It will be moved to the tfm_integration/tfm_psa_test sample CMakeFile. Signed-off-by: Markus Swarowsky <[email protected]> (cherry picked from commit cac7f40) Signed-off-by: Markus Swarowsky <[email protected]>
The sample now builds the psa-arch-tests itself and doesn't rely anymore on the TF-M module CMakeFile. Additionally it will not run the zephyr main.c anymore but therefore only uses the tf-m non-secure application. Signed-off-by: Markus Swarowsky <[email protected]> (cherry picked from commit ad9cdf0) Signed-off-by: Markus Swarowsky <[email protected]>
…r NS application Provide properties for selected TF-M toolchain so that the NS application will use the same toolchain as TF-M. Signed-off-by: Joakim Andersson <[email protected]> Signed-off-by: Markus Swarowsky <[email protected]> (cherry picked from commit 3a83043) Signed-off-by: Markus Swarowsky <[email protected]>
TF-M 2.0.0 doesn't use the TFM_TEST_REPO_PATH anymore so removing it. Upstream PR:zephyrproject-rtos/zephyr#68619 Signed-off-by: Markus Swarowsky <[email protected]>
QCBOR is only needed by the TF-M tests, as they are not build separately due to the TF-M split build By still setting it we get a CMake build warning Upstream PR: zephyrproject-rtos/zephyr#68619 Signed-off-by: Markus Swarowsky <[email protected]>
The TF-M crypto modules got renames from CRYPTO_XXX_MODULE_DISABLED to CRYPTO_XXX_MODULE_ENABLED Therefore also re naming it in zephyr build integration. Upstream PR: zephyrproject-rtos/zephyr#68619 Signed-off-by: Markus Swarowsky <[email protected]>
The new Oberon PSA core (1.2.0) uses new PSA_WANT symbols for the ECC and RSA keys. This adds these new Kconfigs without removing the old ones to avoid necessary changes in the configuration of an application. Signed-off-by: Georgios Vasilakis <[email protected]> Signed-off-by: Markus Swarowsky <[email protected]>
PSA_WANT_ALG_TLS12_PRF and PSA_WANT_ALG_TLS12_PSK_TO_MS rely on HMAC so They should have PSA_WANT_ALG_HMAC as dependency PSA_WANT_ALG_TLS12_ECJPAKE_TO_PMS uses SHA-256 so should have PSA_WANT_ALG_SHA_256 as dependency noup as these algorithms don't exist upstream Signed-off-by: Markus Swarowsky <[email protected]>
…neric fixup! [nrf noup] area: previous short log goes here
This reverts commit 5bb619d.
We moved the header files in sdk-mbedtls from the library folder to the include/library folder. This was done to avoid issues when building MbedTLS with the nrf_security module and the Oberon PSA core. The Oberon PSA core provides a subset of these header files and since they are included with quotes we cannot have them in the same directory. This change make the needed adaptions in CMake for the applications that don't use nrf_security. Signed-off-by: Georgios Vasilakis <[email protected]>
Vge0rge
force-pushed
the
tfm_20_ncs_upmerge_george
branch
from
8b06ea9 to
cf56077
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.