Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop JSON null values on streams #428

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

turb
Copy link
Contributor

@turb turb commented Jan 2, 2025

When sending data with loadJson, empty Option properties are sent as JSON null. While BigQuery then stores it as a column null for almost all column types, it is not the case with JSON column types.

For example:

  • load with None => stored as JSON null (not column null)
  • pull => returns Some(null)

The change is simple: just remove the null JSON properties so that BigQuery always stores a DB null, even with the JSON column type.

@turb
Copy link
Contributor Author

turb commented Jan 7, 2025

Hello @mariuene @TSommerdal, do you think it would be possible to review / merge / release this?

Many thanks!

Copy link
Contributor

@TSommerdal TSommerdal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello. This looks like it can be merged without any problems :)

@TSommerdal TSommerdal merged commit d4420d8 into nrkno:main Jan 8, 2025
3 of 5 checks passed
@turb
Copy link
Contributor Author

turb commented Jan 8, 2025

(Wonderful! Do you have plans for a release?)

edit: wow already released, thanks!

@TSommerdal
Copy link
Contributor

@TSommerdal
Copy link
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants