fix: UIBlueprintUpgradeStatuses crashing if no playlists in the system

nrkno · Nov 15, 2023 · 3491ec5 · 3491ec5
1 parent 54d6719
commit 3491ec5
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 21 deletions.
diff --git a/meteor/client/ui/Settings/Upgrades/View.tsx b/meteor/client/ui/Settings/Upgrades/View.tsx
@@ -24,9 +24,11 @@ export function UpgradesView(): JSX.Element {
 
 				<table className="table">
 					<thead>
-						<th>Name</th>
-						<th>&nbsp;</th>
-						<th>&nbsp;</th>
+						<tr>
+							<th>Name</th>
+							<th>&nbsp;</th>
+							<th>&nbsp;</th>
+						</tr>
 					</thead>
 					<tbody>
 						{isReady && statuses && statuses.length === 0 && (

diff --git a/meteor/server/publications/blueprintUpgradeStatus/publication.ts b/meteor/server/publications/blueprintUpgradeStatus/publication.ts
@@ -1,8 +1,7 @@
 import { BlueprintId, ShowStyleBaseId, StudioId } from '@sofie-automation/corelib/dist/dataModel/Ids'
-import { MongoFieldSpecifierOnesStrict } from '@sofie-automation/corelib/dist/mongo'
 import { ReadonlyDeep } from 'type-fest'
 import { CustomCollectionName, MeteorPubSub } from '../../../lib/api/pubsub'
-import { literal, ProtectedString, protectString } from '../../../lib/lib'
+import { ProtectedString, protectString } from '../../../lib/lib'
 import {
 	CustomPublish,
 	CustomPublishCollection,
@@ -16,8 +15,6 @@ import { NoSecurityReadAccess } from '../../security/noSecurity'
 import { LiveQueryHandle } from '../../lib/lib'
 import { ContentCache, createReactiveContentCache, ShowStyleBaseFields, StudioFields } from './reactiveContentCache'
 import { UpgradesContentObserver } from './upgradesContentObserver'
-import { DBRundownPlaylist } from '@sofie-automation/corelib/dist/dataModel/RundownPlaylist'
-import { RundownPlaylists } from '../../collections'
 import { BlueprintMapEntry, checkDocUpgradeStatus } from './checkStatus'
 import { BlueprintManifestType } from '@sofie-automation/blueprints-integration'
 import { DBShowStyleBase } from '@sofie-automation/corelib/dist/dataModel/ShowStyleBase'
@@ -38,23 +35,10 @@ interface BlueprintUpgradeStatusUpdateProps {
 	invalidateBlueprintIds: BlueprintId[]
 }
 
-type RundownPlaylistFields = '_id' | 'studioId'
-const rundownPlaylistFieldSpecifier = literal<
-	MongoFieldSpecifierOnesStrict<Pick<DBRundownPlaylist, RundownPlaylistFields>>
->({
-	_id: 1,
-	studioId: 1,
-})
-
 async function setupBlueprintUpgradeStatusPublicationObservers(
-	args: ReadonlyDeep<BlueprintUpgradeStatusArgs>,
+	_args: ReadonlyDeep<BlueprintUpgradeStatusArgs>,
 	triggerUpdate: TriggerUpdate<BlueprintUpgradeStatusUpdateProps>
 ): Promise<LiveQueryHandle[]> {
-	const playlist = (await RundownPlaylists.findOneAsync(args.playlistId, {
-		projection: rundownPlaylistFieldSpecifier,
-	})) as Pick<DBRundownPlaylist, RundownPlaylistFields> | undefined
-	if (!playlist) throw new Error(`RundownPlaylist "${args.playlistId}" not found!`)
-
 	// TODO - can this be done cheaper?
 	const cache = createReactiveContentCache()