Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CasparCG restart error: Timeout after 10000ms SOFIE-2588 #1042

Merged
merged 9 commits into from
Oct 6, 2023

Conversation

Julusian
Copy link
Member

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

fix

  • What is the new behavior (if this is a feature change)?

The handling of cronjob CasparCG restarts is improved to produce more better errors, and minimise logging at the error level.

Additionally, some typings for the ui have improved for executing tsr actions.

This relies on nrkno/sofie-timeline-state-resolver#295 for accurate logging

  • Other information:

Status

  • Code documentation for the relevant parts in the code have been added/updated by the PR author
  • The functionality has been tested by the PR author
  • The functionality has been tested by NRK

@Julusian Julusian requested a review from a team September 29, 2023 16:15
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (685ddb6) 58.06% compared to head (ec40214) 58.25%.
Report is 38 commits behind head on release50.

Additional details and impacted files
@@              Coverage Diff              @@
##           release50    #1042      +/-   ##
=============================================
+ Coverage      58.06%   58.25%   +0.19%     
=============================================
  Files            479      479              
  Lines          78378    78466      +88     
  Branches        4093     4233     +140     
=============================================
+ Hits           45510    45711     +201     
+ Misses         32808    32695     -113     
  Partials          60       60              
Files Coverage Δ
meteor/lib/api/client.ts 100.00% <100.00%> (ø)
...eor/server/api/peripheralDevice/executeFunction.ts 98.74% <100.00%> (+0.15%) ⬆️
meteor/client/lib/clientAPI.ts 0.00% <0.00%> (ø)
meteor/server/cronjobs.ts 91.91% <96.52%> (+7.50%) ⬆️
meteor/server/api/client.ts 75.20% <64.51%> (-1.23%) ⬇️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

meteor/server/cronjobs.ts Outdated Show resolved Hide resolved
meteor/server/cronjobs.ts Show resolved Hide resolved
@jstarpl
Copy link
Member

jstarpl commented Oct 6, 2023

@Julusian
Copy link
Member Author

Julusian commented Oct 6, 2023

@jstarpl fixed

@jstarpl jstarpl self-requested a review October 6, 2023 13:46
@Julusian Julusian merged commit 394aa47 into release50 Oct 6, 2023
66 checks passed
@Julusian Julusian deleted the fix/casparcg-restart-timeout branch October 6, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants