Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid doing [0] on a promise instead of on the awaited result #1047

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

Julusian
Copy link
Member

@Julusian Julusian commented Oct 6, 2023

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Bug fix

  • What is the current behavior? (You can also link to an open issue here)

This is a couple of lines that look to be actual bugs, when I found when enabling noImplicitAny in the typescript config

  • Other information:

Status

  • Code documentation for the relevant parts in the code have been added/updated by the PR author
  • The functionality has been tested by the PR author
  • Automated tests to cover the new functionality and/or guard against regressions have been added
  • The functionality has been tested by NRK

@Julusian Julusian requested a review from a team October 6, 2023 15:48
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (ef4a86f) 58.05% compared to head (a782176) 58.15%.
Report is 3 commits behind head on release50.

Additional details and impacted files
@@              Coverage Diff              @@
##           release50    #1047      +/-   ##
=============================================
+ Coverage      58.05%   58.15%   +0.10%     
=============================================
  Files            479      479              
  Lines          78390    78470      +80     
  Branches        4097     4151      +54     
=============================================
+ Hits           45508    45633     +125     
+ Misses         32821    32780      -41     
+ Partials          61       57       -4     
Files Coverage Δ
meteor/server/api/cleanup.ts 100.00% <100.00%> (ø)
meteor/server/api/ExternalMessageQueue.ts 68.14% <0.00%> (+0.59%) ⬆️

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Julusian Julusian merged commit b8a79bc into release50 Oct 13, 2023
65 of 66 checks passed
@Julusian Julusian deleted the fix/implicit-any-bugs branch October 13, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants