-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Playlist and part timings on live status gateway #1059
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release51 #1059 +/- ##
==============================================
+ Coverage 58.20% 81.36% +23.15%
==============================================
Files 507 142 -365
Lines 81414 27361 -54053
Branches 4279 2231 -2048
==============================================
- Hits 47391 22262 -25129
+ Misses 33965 5072 -28893
+ Partials 58 27 -31
☔ View full report in Codecov by Sentry. |
cc70da5
to
cc9401a
Compare
I've just realised that #1053 covers some of this already, if that PR gets accepted I'll tweak this one to just do playlist timing and metadata. |
I'm wondering, what's the specific use case for exposing the PartInstance metadata to the API consumers? I think so far we've seen the Metadata property as a private datastore owned by the blueprints. One option we were looking at was a namespaced public datastore that could be consumed by various consumers and potentially cross-compatible between blueprints (via some yet-to-be-defined extension proposal process?). Or maybe this is data that could be otherwise compiled somehow already, just that it's difficult and we need to expand some feature area? |
A simple example would be a countdown system with audible counts which require different counting styles / voices depending on the type of item being counted. |
Does it have to be the same We should probably rename these fields to |
That would work for me, we're not currently putting anything quite that significant into the metaData field, although I'd agree most of what's in there isn't much use externally. |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
Timings information isn't available in the live status gateway
What is the new behavior (if this is a feature change)?
Playlist and part timing is available in the live status gateway
Other information:
Status