Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Playout ignores 'Play from here' offset SOFIE-2356 #1063

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

Julusian
Copy link
Member

@Julusian Julusian commented Nov 1, 2023

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

bug fix

  • What is the current behavior? (You can also link to an open issue here)

Using the 'play from here' context menu option will always play from the start of the selected part

  • What is the new behavior (if this is a feature change)?

It now plays from the correct point within the part

  • Other information:

Status

  • Code documentation for the relevant parts in the code have been added/updated by the PR author
  • The functionality has been tested by the PR author
  • Automated tests to cover the new functionality and/or guard against regressions have been added
  • The functionality has been tested by NRK

@Julusian Julusian requested a review from nytamin November 1, 2023 15:06
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dfebb3f) 58.21% compared to head (1aa054c) 44.87%.
Report is 4 commits behind head on release51.

Additional details and impacted files
@@              Coverage Diff               @@
##           release51    #1063       +/-   ##
==============================================
- Coverage      58.21%   44.87%   -13.35%     
==============================================
  Files            507      345      -162     
  Lines          81418    52252    -29166     
  Branches        4282     1857     -2425     
==============================================
- Hits           47397    23447    -23950     
+ Misses         33963    28777     -5186     
+ Partials          58       28       -30     

see 165 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nytamin nytamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a simple and elegant solution!

@Julusian Julusian merged commit 479154a into release51 Nov 6, 2023
65 of 66 checks passed
@Julusian Julusian deleted the fix/play-offset branch November 6, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants