-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Element Selector for UI #1305
feat: Element Selector for UI #1305
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am I correct in understanding that there will be another PR coming for release52
with the implementation of Selection for other Segment View modes and AdLib list in the Shelf? I think it's important that this works across all Rundown View components?
packages/webui/src/client/ui/SegmentTimeline/SegmentTimelineContainer.tsx
Outdated
Show resolved
Hide resolved
packages/webui/src/client/ui/RundownView/SelectedElementsContext.tsx
Outdated
Show resolved
Hide resolved
packages/webui/src/client/ui/RundownView/SelectedElementsContext.tsx
Outdated
Show resolved
Hide resolved
packages/webui/src/client/ui/SegmentTimeline/SegmentTimelineContainer.tsx
Outdated
Show resolved
Hide resolved
packages/webui/src/client/ui/SegmentTimeline/SegmentTimelineContainer.tsx
Outdated
Show resolved
Hide resolved
packages/webui/src/client/ui/SegmentTimeline/SegmentTimelineContainer.tsx
Outdated
Show resolved
Hide resolved
Yes, the segmentTimeline implementation is just to guide an implementation. |
…ntainer.tsx Co-authored-by: Jan Starzak <[email protected]>
packages/webui/src/client/ui/RundownView/SelectedElementsContext.tsx
Outdated
Show resolved
Hide resolved
We need to solve a few merge errors and build issues before we can merge this. |
…-selector-for-ui # Conflicts: # packages/webui/src/client/ui/RundownView.tsx # packages/webui/src/client/ui/SegmentTimeline/SegmentTimelineContainer.tsx
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release52 #1305 +/- ##
==============================================
+ Coverage 61.31% 83.14% +21.83%
==============================================
Files 468 154 -314
Lines 82107 30745 -51362
Branches 4684 2568 -2116
==============================================
- Hits 50340 25564 -24776
+ Misses 31674 5149 -26525
+ Partials 93 32 -61 ☔ View full report in Codecov by Sentry. |
This will be a part of the upcoming Properties panel, so this PR will be closed. |
About the Contributor
This PR is made on the behalf of BBC
Type of Contribution
This is the framework for selecting elements in UI
Current Behavior
Currently there's no easy way to communicate if something in the UI is selected
New Behavior
This PR adds a SelectedElements Contextprovider in top of rundown tree, so selection of e.g. a segment is reflected in properties panel propertiespanel.
It's a minimal implementation, and the full selection in UI will be added in a PR for the Properties Panel.
Testing
Unit test has been made, and inclusion of
@testing-library/react
so it's possible to test via the provider.Affected areas
@testing-library/react
)Time Frame
This PR should be merged soon, so it can be merged back to bbc.
Status
this is ready to be reviewed