Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: RundownView shows spinner when unMOSing a Rundown from a Playlist (SOFIE-3539) #1311

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

jstarpl
Copy link
Member

@jstarpl jstarpl commented Nov 4, 2024

About the Contributor

This pull request is posted on behalf of the NRK.

Type of Contribution

This is a:

Bug fix

Current Behavior

The RundownView will show a spinner when removing a Rundown from a Playlist, e.g. via MOS active

New Behavior

The RundownView should now be stable, however the ShowStyleVariants publication ready state may not be accurate.

Testing

  • I have added one or more unit tests for this PR
  • I have updated the relevant unit tests
  • No unit test changes are needed for this PR

Affected areas

  • This PR affect the RundownView

Time Frame

This Bug Fix is critical for us, please review and merge it as soon as possible.

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@jstarpl jstarpl requested a review from a team as a code owner November 4, 2024 12:03
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.09%. Comparing base (8bded15) to head (13f0556).
Report is 52 commits behind head on release51.

Additional details and impacted files
@@              Coverage Diff              @@
##           release51    #1311      +/-   ##
=============================================
+ Coverage      57.90%   58.09%   +0.18%     
=============================================
  Files            526      525       -1     
  Lines          84973    85094     +121     
  Branches        4394     4599     +205     
=============================================
+ Hits           49207    49432     +225     
+ Misses         35740    35631     -109     
- Partials          26       31       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jstarpl jstarpl merged commit 02b8594 into release51 Nov 29, 2024
78 of 80 checks passed
@jstarpl jstarpl deleted the fix/sofie-3593/show-style-variants-sub branch November 29, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants