Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Unable to clear infinites #1324

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

Julusian
Copy link
Contributor

About the Contributor

This pull request is posted on behalf of the BBC

Type of Contribution

This is a: Bug fix

Current Behavior

This looks to have been introduced by #1276

To reproduce:

  1. Take an infinite (Out on Rundown Change)
  2. Clear the layer via an AdLib Action stopPiecesOnLayers or stopPieceInstances
  3. Take the infinite again
  4. Clear the layer via an AdLib Action stopPiecesOnLayers or stopPieceInstances
  5. Observe error in UI and logs
    Error: Error in generated timeline: Validation failed: Error: "enable.end" and "enable.duration" cannot be combined

Testing

  • I have added one or more unit tests for this PR
  • I have updated the relevant unit tests
  • No unit test changes are needed for this PR

Affected areas

Time Frame

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@Julusian Julusian added the Contribution from BBC Contributions sponsored by BBC (bbc.co.uk) label Nov 18, 2024
@Julusian Julusian requested a review from a team as a code owner November 18, 2024 12:34
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.32%. Comparing base (c5b833d) to head (a9daca2).
Report is 91 commits behind head on release52.

Files with missing lines Patch % Lines
...ackages/job-worker/src/playout/timeline/rundown.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           release52    #1324      +/-   ##
=============================================
- Coverage      60.61%   60.32%   -0.29%     
=============================================
  Files            459      461       +2     
  Lines          78733    79360     +627     
  Branches        4849     5059     +210     
=============================================
+ Hits           47721    47877     +156     
- Misses         30871    31341     +470     
- Partials         141      142       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jstarpl jstarpl merged commit c58d6ba into nrkno:release52 Nov 26, 2024
45 of 46 checks passed
@Julusian Julusian deleted the upstream/fix-infinite-end-and-duration branch November 27, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution from BBC Contributions sponsored by BBC (bbc.co.uk)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants