fix: the scss structure reimporting multiple times #1335
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the Contributor
this PR is made on the behalf of BBC
Type of Contribution
This is a:
Bug fix
Current Behavior
Currently the scss files is reimporting the same .scss files multiple times, ending up with a css styles stack of 144 :root elements.
New Behavior
The imports are done in the main.scss and removed in the sub scss files, as their already shared by the main.scss
Testing
It has been tested, going through the different components. But as all these 114 :root styles was identical, it shouldn't cause any issues.
Affected areas
CSS - UI
Status