Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the scss structure reimporting multiple times #1335

Merged

Conversation

olzzon
Copy link
Contributor

@olzzon olzzon commented Dec 4, 2024

About the Contributor

this PR is made on the behalf of BBC

Type of Contribution

This is a:
Bug fix

Current Behavior

Currently the scss files is reimporting the same .scss files multiple times, ending up with a css styles stack of 144 :root elements.

New Behavior

The imports are done in the main.scss and removed in the sub scss files, as their already shared by the main.scss

Testing

It has been tested, going through the different components. But as all these 114 :root styles was identical, it shouldn't cause any issues.

  • I have added one or more unit tests for this PR
  • I have updated the relevant unit tests
  • No unit test changes are needed for this PR

Affected areas

CSS - UI

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

…places. This is now replaced to be only in main.scss
@olzzon olzzon requested a review from a team as a code owner December 4, 2024 10:31
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.41%. Comparing base (1d87ef1) to head (8b926ac).
Report is 232 commits behind head on release52.

Additional details and impacted files
@@              Coverage Diff              @@
##           release52    #1335      +/-   ##
=============================================
- Coverage      60.68%   60.41%   -0.28%     
=============================================
  Files            459      461       +2     
  Lines          78126    79486    +1360     
  Branches        3599     4492     +893     
=============================================
+ Hits           47414    48018     +604     
- Misses         30516    31343     +827     
+ Partials         196      125      -71     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Julusian Julusian added the Contribution from BBC Contributions sponsored by BBC (bbc.co.uk) label Dec 4, 2024
@jstarpl jstarpl self-assigned this Dec 5, 2024
@jstarpl jstarpl merged commit 162af01 into nrkno:release52 Dec 9, 2024
45 of 46 checks passed
@Julusian Julusian deleted the upstream/pr-over-onehundres-css-styles-layers branch December 10, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution from BBC Contributions sponsored by BBC (bbc.co.uk)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants