-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(UI): presenter timing part segment remaining #1346
Open
olzzon
wants to merge
8
commits into
nrkno:release53
Choose a base branch
from
bbc:upstream/presenter-timing-part-segment-remaining
base: release53
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(UI): presenter timing part segment remaining #1346
olzzon
wants to merge
8
commits into
nrkno:release53
from
bbc:upstream/presenter-timing-part-segment-remaining
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release52 #1346 +/- ##
=============================================
- Coverage 56.49% 56.47% -0.03%
=============================================
Files 401 401
Lines 72019 71925 -94
Branches 4550 4555 +5
=============================================
- Hits 40687 40617 -70
+ Misses 31195 31060 -135
- Partials 137 248 +111 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the Contributor
This PR is made on behalf of BBC
Type of Contribution
This is a feature and UI improvements
Current Behavior
Currently the timers in presenter is using the that follows the NRK specs.
PiceIcons have issues when not using numbers e.g. Cam 1, 2, 3 or LIVE 1, 2, 3
New Behavior
CountdownType.SEGMENT_BUDGET_DURATION:
If CountdownType.SEGMENT_BUDGET_DURATION is set as countdownType the
<CurrentPartOrSegmentRemaining/>
component will be used instead of the<PieceCountdownContainer>
If not SEGMENT_BUDGET_DURATION the presenter functionality is not changed.
Abbreviation now differentiate between '' or undefined, so it's possible have no abbreviation:
(Before it always added "LIVE" in front even if it was an empty string '')
As studioLabel can be to long to be used (some broadcasters it's just a number, others it's a longer label) a studioLabelShort optional has been added, so it's possible to create short 3-4 letter camera labels for presenterview:
(in this example it's just a slice of the camera name)
The font and weight has been unified on all PieceIcons
Testing
Affected areas
This affects only presenter screen. The counter is only affected if CountdownType.SEGMENT_BUDGET_DURATION is being used.
The UI only has changes on the PiceIcons
Time Frame
Other Information
Status