Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(UI): presenter timing part segment remaining #1346

Open
wants to merge 8 commits into
base: release53
Choose a base branch
from

Conversation

olzzon
Copy link
Contributor

@olzzon olzzon commented Dec 17, 2024

About the Contributor

This PR is made on behalf of BBC

Type of Contribution

This is a feature and UI improvements

Current Behavior

Currently the timers in presenter is using the that follows the NRK specs.
PiceIcons have issues when not using numbers e.g. Cam 1, 2, 3 or LIVE 1, 2, 3

New Behavior

CountdownType.SEGMENT_BUDGET_DURATION:

If CountdownType.SEGMENT_BUDGET_DURATION is set as countdownType the <CurrentPartOrSegmentRemaining/> component will be used instead of the <PieceCountdownContainer>
If not SEGMENT_BUDGET_DURATION the presenter functionality is not changed.

Abbreviation now differentiate between '' or undefined, so it's possible have no abbreviation:

(Before it always added "LIVE" in front even if it was an empty string '')

		{
			_id: PgmVideoSourceLayer.OS,
			name: 'Live',
			abbreviation: '',
			type: SourceLayerType.REMOTE,
..........
		

As studioLabel can be to long to be used (some broadcasters it's just a number, others it's a longer label) a studioLabelShort optional has been added, so it's possible to create short 3-4 letter camera labels for presenterview:

(in this example it's just a slice of the camera name)

	return {
		...getBlueprintPieceBaseProps(props, pieceProps),
		name: pieceName,
		sourceLayerId: PgmVideoSourceLayer.Camera,
		outputLayerId: OutputLayer.PGM,
		content: {
			studioLabel: pieceName,
			studioLabelShort: String(camera).slice(0, 3),
			switcherInput,
			timelineObjects: [
.............

The font and weight has been unified on all PieceIcons

Testing

  • I have added one or more unit tests for this PR
  • I have updated the relevant unit tests
  • No unit test changes are needed for this PR

Affected areas

This affects only presenter screen. The counter is only affected if CountdownType.SEGMENT_BUDGET_DURATION is being used.
The UI only has changes on the PiceIcons

Time Frame

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.47%. Comparing base (1848f9e) to head (e217db1).
Report is 78 commits behind head on release52.

Additional details and impacted files
@@              Coverage Diff              @@
##           release52    #1346      +/-   ##
=============================================
- Coverage      56.49%   56.47%   -0.03%     
=============================================
  Files            401      401              
  Lines          72019    71925      -94     
  Branches        4550     4555       +5     
=============================================
- Hits           40687    40617      -70     
+ Misses         31195    31060     -135     
- Partials         137      248     +111     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Julusian Julusian added the Contribution from BBC Contributions sponsored by BBC (bbc.co.uk) label Dec 18, 2024
@nytamin nytamin added the Contribution External contribution label Jan 29, 2025
@nytamin nytamin changed the base branch from release52 to release53 February 4, 2025 14:17
@olzzon olzzon marked this pull request as ready for review February 5, 2025 08:38
@olzzon olzzon requested a review from a team as a code owner February 5, 2025 08:38
@jstarpl jstarpl changed the title Upstream/presenter timing part segment remaining feat(UI): presenter timing part segment remaining Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution from BBC Contributions sponsored by BBC (bbc.co.uk) Contribution External contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants