Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make sure that Playout Gateway never puts an object into the message field of the JSONL log output (SOFIE-3679) #1353

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

jstarpl
Copy link
Member

@jstarpl jstarpl commented Dec 19, 2024

About the Contributor

This pull request is posted on behalf of the NRK.

Type of Contribution

This is a:

Bug fix

Current Behavior

Sometimes, Playout Gateway outputs an object as the "message" member of the JSONL-formated logging output to std streams.

New Behavior

Message is ensured not to be an object.

Testing

  • I have added one or more unit tests for this PR
  • I have updated the relevant unit tests
  • No unit test changes are needed for this PR

Affected areas

  • This PR affects logging

Time Frame

  • We intend to finish the development on this feature in two weeks time.

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@jstarpl jstarpl requested a review from a team as a code owner December 19, 2024 15:28
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.00%. Comparing base (d2a3cdf) to head (0d2b844).

Additional details and impacted files
@@              Coverage Diff              @@
##           release51    #1353      +/-   ##
=============================================
+ Coverage      57.96%   58.00%   +0.04%     
=============================================
  Files            525      525              
  Lines          85164    85164              
  Branches        4428     4464      +36     
=============================================
+ Hits           49362    49399      +37     
+ Misses         35798    35732      -66     
- Partials           4       33      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jstarpl jstarpl merged commit 255c27c into release51 Jan 8, 2025
78 of 81 checks passed
@jstarpl jstarpl deleted the fix/sofie-3679/pogw-log-output branch January 8, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants