-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/http makeready can reset state #142
Conversation
@nytamin as we discussed, there is now a queue in conductor. Instead of using syncFunction, I opted to use an off the shelf queue for promises Additionally, I went though any uses of Promise.all and they are now using |
During this I hit what appears to be #139, so have left one use of Promise.all which would be nice to remove also. Also this appears to break support for node8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (pending actual testing ;) )
07815ef
to
96d0410
Compare
Codecov Report
@@ Coverage Diff @@
## master #142 +/- ##
==========================================
- Coverage 76.48% 76.45% -0.04%
==========================================
Files 42 42
Lines 4853 4851 -2
Branches 1092 1099 +7
==========================================
- Hits 3712 3709 -3
- Misses 1097 1098 +1
Partials 44 44
Continue to review full report at Codecov.
|
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Other information: