Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Sisyfos): add sisyfos action to load mixer preset #360

Draft
wants to merge 1 commit into
base: release52
Choose a base branch
from

Conversation

ianshade
Copy link
Contributor

About the Contributor

This pull request is posted on behalf of TV 2 Norge

Type of Contribution

This is a:

Feature

Current Behavior

No way to load a mixer preset using TSR.

New Behavior

TSR action is added, that allows to load a specified mixer preset.

Testing Instructions

Other Information

It's a draft, because complementary changes haven't been yet contributed upstream in Sisyfos

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 13.04348% with 20 lines in your changes missing coverage. Please review.

Project coverage is 56.46%. Comparing base (3e5de55) to head (8895f87).

Files with missing lines Patch % Lines
...e-state-resolver/src/integrations/sisyfos/index.ts 0.00% 13 Missing and 1 partial ⚠️
...te-resolver/src/integrations/sisyfos/connection.ts 14.28% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           release52     #360      +/-   ##
=============================================
- Coverage      56.55%   56.46%   -0.09%     
=============================================
  Files            131      131              
  Lines          10274    10293      +19     
  Branches        2509     2565      +56     
=============================================
+ Hits            5810     5812       +2     
+ Misses          4462     4109     -353     
- Partials           2      372     +370     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants