Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use zap for http access logging #148

Merged
merged 2 commits into from
Dec 18, 2023
Merged

feat: use zap for http access logging #148

merged 2 commits into from
Dec 18, 2023

Conversation

stigok
Copy link
Collaborator

@stigok stigok commented Dec 18, 2023 •
edited
Loading

Closes #54

@stigok stigok force-pushed the 54-use-zap-for-request-access-log branch 2 times, most recently from c2f42a9 to cb3d9b0 Compare December 18, 2023 13:18
@stigok stigok marked this pull request as ready for review December 18, 2023 13:19
@stigok stigok requested a review from a team as a code owner December 18, 2023 13:19
@stigok stigok requested review from umglurf, martinsolberg and arott and removed request for a team December 18, 2023 13:19
@stigok stigok mentioned this pull request Dec 18, 2023
Merged
1 task
Foxboron
Foxboron reviewed Dec 18, 2023
View reviewed changes
pkg/registry/registry.go Outdated
// written by Manfred Touron, licensed under the MIT license.
//
//
// Copyright (c) 2021 Manfred Touron <[email protected]> (manfred.life)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overkill to copy the entire license into the file :) It's fine to just link to the code with an external link and inlcude the SPDX identifier.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reworked!

Foxboron
Foxboron previously approved these changes Dec 18, 2023
View reviewed changes
@stigok stigok force-pushed the 54-use-zap-for-request-access-log branch from cb3d9b0 to dcd1c1b Compare December 18, 2023 14:35
@stigok stigok requested a review from Foxboron December 18, 2023 14:35
@stigok stigok force-pushed the 54-use-zap-for-request-access-log branch from dcd1c1b to 943f56b Compare December 18, 2023 14:53
@stigok stigok force-pushed the 54-use-zap-for-request-access-log branch from 918e587 to 5d5a1be Compare December 18, 2023 14:55
@stigok stigok merged commit 44353f8 into main Dec 18, 2023
10 checks passed
@stigok stigok deleted the 54-use-zap-for-request-access-log branch December 18, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Foxboron Foxboron Foxboron approved these changes

@umglurf umglurf Awaiting requested review from umglurf umglurf is a code owner automatically assigned from nrkno/iac-admins

@martinsolberg martinsolberg Awaiting requested review from martinsolberg martinsolberg is a code owner automatically assigned from nrkno/iac-admins

@arott arott Awaiting requested review from arott arott is a code owner automatically assigned from nrkno/iac-admins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move HTTP logging into new log framework
2 participants
@stigok @Foxboron