Skip to content

Commit

Permalink
fix(bundling): remove migration always adding sass-embedded (#30276)
Browse files Browse the repository at this point in the history
## Current Behavior
There is a migration that always adds `sass-embedded` for Rspack and
Webpack for 20.5

## Expected Behavior
`sass-embedded` is already a dependency of Rspack and Webpack and
therefore does not need to be added to users package.json - especially
as they may not be using it.
  • Loading branch information
Coly010 authored Mar 5, 2025
1 parent 7ba707e commit 648129f
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@
"name": "20.5.0-package-updates",
"version": "20.5.0-beta.4",
"packages": {
"sass-embedded": { "version": "^1.83.4", "alwaysAddToPackageJson": true },
"sass-loader": { "version": "^16.0.4", "alwaysAddToPackageJson": true },
"sass-loader": { "version": "^16.0.4", "alwaysAddToPackageJson": false },
"@rspack/core": { "version": "^1.2.2", "alwaysAddToPackageJson": false }
},
"aliases": [],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@
"name": "20.5.0-package-updates",
"version": "20.5.0-beta.3",
"packages": {
"sass-loader": { "version": "^16.0.4", "alwaysAddToPackageJson": false },
"sass-embedded": { "version": "^1.83.4", "alwaysAddToPackageJson": true }
"sass-loader": { "version": "^16.0.4", "alwaysAddToPackageJson": false }
},
"aliases": [],
"description": "",
Expand Down
6 changes: 1 addition & 5 deletions packages/rspack/migrations.json
Original file line number Diff line number Diff line change
Expand Up @@ -98,13 +98,9 @@
"20.5.0": {
"version": "20.5.0-beta.4",
"packages": {
"sass-embedded": {
"version": "^1.83.4",
"alwaysAddToPackageJson": true
},
"sass-loader": {
"version": "^16.0.4",
"alwaysAddToPackageJson": true
"alwaysAddToPackageJson": false
},
"@rspack/core": {
"version": "^1.2.2",
Expand Down
4 changes: 0 additions & 4 deletions packages/webpack/migrations.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,6 @@
"sass-loader": {
"version": "^16.0.4",
"alwaysAddToPackageJson": false
},
"sass-embedded": {
"version": "^1.83.4",
"alwaysAddToPackageJson": true
}
}
}
Expand Down

0 comments on commit 648129f

Please sign in to comment.