Skip to content

Commit

Permalink
fix(core): disable daemon in postinstall (#27415)
Browse files Browse the repository at this point in the history
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

Daemon is stopped.. but then started in the postinstall process. The
results might be premature and cause issues for subsequent commands.

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

Daemon is stopped... and disabled in postinstall process. This won't
cause issues for subsequent commands.

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
  • Loading branch information
FrozenPandaz committed Aug 13, 2024
1 parent 54f52bb commit 6d83ae2
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions packages/nx/bin/post-install.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ import { logger } from '../src/utils/logger';
if (isNxCloudUsed(readNxJson())) {
tasks.push(verifyOrUpdateNxCloudClient(getCloudOptions()));
}

process.env.NX_DAEMON = 'false';
await Promise.all(
tasks.map((promise) => {
return promise.catch((e) => {
Expand Down

0 comments on commit 6d83ae2

Please sign in to comment.