fix(core): ignore root projects for project inference #17949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 925a34e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Cammisuli
approved these changes
Jul 4, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When we moved from
fast-glob(Node) toglobset(Rust), we started to pick up root project configurations. This creates an issue where the root project which would containjest.config.jswould only be defined by a project created by a plugin's project graph plugin. The JS code analysis would try to draw dependencies to a node which will only be defined when the plugin's projecft graph plugin runs resulting in a error.Expected Behavior
For now, we will recreate the same behavior as
fast-globusingglobset. Plugins inference APIs will not be able to define root projects just like before.In the near future, we will change the project graph logic to allow for plugin inference APIs to define root projects but that is out of scope for this fix.
Related Issue(s)
Fixes Cammisuli/monodon#23 (comment)