-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): Remove nameAndDirectoryFormat option from generators #28110
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
packages/devkit/src/generators/artifact-name-and-directory-utils.ts
Outdated
Show resolved
Hide resolved
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 4468584. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 5 targets
Sent with 💌 from NxCloud. |
a9a6d4d
to
6d55a44
Compare
34d1eb9
to
f5767b3
Compare
f5767b3
to
e21adb5
Compare
e21adb5
to
ca68a72
Compare
0112af8
to
cb7b954
Compare
fe65e46
to
088086c
Compare
088086c
to
f737e61
Compare
f737e61
to
c43f162
Compare
c43f162
to
0366daf
Compare
0366daf
to
4b86afa
Compare
4b86afa
to
4468584
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
Currently, when we use generator's via the CLI passing the
name
arg has more than one responsibility:This is not intuitive as if we use via Nx Console because it creates some ambiguity around the
--name
property which is normally described as only 2.Expected Behavior
What is expected is that the
name
property should only have the responsibility of determining the name of the generated module (Component, Directive etc...).The new property
path
replaces thedirectory
property but fulfils the same purpose as determining where the module should be created.Related Issue(s)
Fixes #