Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(js): allow publishable library to run release command #29775

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(js): allow publishable library to run release command #29775

wants to merge 1 commit into from

Conversation

xiongemi
Copy link
Collaborator

@xiongemi xiongemi commented Jan 28, 2025 •
edited
Loading

Current Behavior

  • there is no option fallbackCurrentVersionResolver: 'disk',
  • can't run release for newly created publishable libraries

Expected Behavior

  • move code to add release for publishable libraries into its own file to be reused by other stacks
  • add fallbackCurrentVersionResolver: 'disk', to project's release.version. generatorOptions

Related Issue(s)

Fixes #29723

@xiongemi xiongemi requested review from a team as code owners January 28, 2025 06:27
@vercel Vercel
Copy link

vercel bot commented Jan 28, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 4:02pm

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jan 28, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 506781d.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 8m 12s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 20s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base= --he... ✅ Succeeded 11s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 9s View ↗
nx documentation ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-07 16:12:56 UTC

@xiongemi xiongemi force-pushed the feature/nxc-1383-release-command-does-not-work-for-nxjslib-publishable branch 2 times, most recently from dcfe278 to ce3fe9e Compare January 28, 2025 07:08
@xiongemi xiongemi force-pushed the feature/nxc-1383-release-command-does-not-work-for-nxjslib-publishable branch 4 times, most recently from a71555f to 0762eb6 Compare February 4, 2025 06:05
@xiongemi xiongemi requested a review from a team as a code owner February 4, 2025 06:52
@xiongemi xiongemi force-pushed the feature/nxc-1383-release-command-does-not-work-for-nxjslib-publishable branch from fe594f1 to 0762eb6 Compare February 4, 2025 06:57
JamesHenry
JamesHenry requested changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly +1'ing Leo's feedback but also a note about needing to support the workspaces + TS project references setup

packages/js/src/utils/npm-config.ts Outdated Show resolved Hide resolved
e2e/release/src/publishable-libraries-release.test.ts Outdated Show resolved Hide resolved
packages/js/src/generators/library/library.spec.ts Outdated Show resolved Hide resolved
packages/js/src/generators/library/utils/add-release-config.ts Outdated Show resolved Hide resolved
@xiongemi xiongemi force-pushed the feature/nxc-1383-release-command-does-not-work-for-nxjslib-publishable branch 2 times, most recently from 3d0d1bd to 25b881e Compare February 6, 2025 03:52
@xiongemi xiongemi force-pushed the feature/nxc-1383-release-command-does-not-work-for-nxjslib-publishable branch from 25b881e to 1a874c9 Compare February 7, 2025 05:34
@xiongemi xiongemi requested a review from leosvelperez February 7, 2025 06:29
@xiongemi xiongemi force-pushed the feature/nxc-1383-release-command-does-not-work-for-nxjslib-publishable branch 2 times, most recently from 37f3a20 to 0759294 Compare February 7, 2025 06:41
@xiongemi xiongemi force-pushed the feature/nxc-1383-release-command-does-not-work-for-nxjslib-publishable branch from 0759294 to 506781d Compare February 7, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cammisuli Cammisuli Awaiting requested review from Cammisuli Cammisuli is a code owner automatically assigned from nrwl/nx-core-reviewers

@FrozenPandaz FrozenPandaz Awaiting requested review from FrozenPandaz FrozenPandaz was automatically assigned from nrwl/nx-devkit-reviewers

@jaysoo jaysoo Awaiting requested review from jaysoo jaysoo was automatically assigned from nrwl/nx-docs-reviewers

@JamesHenry JamesHenry Awaiting requested review from JamesHenry

@leosvelperez leosvelperez Awaiting requested review from leosvelperez

Requested changes must be addressed to merge this pull request.

Assignees

@xiongemi xiongemi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release group "__default__" matches no projects. Please ensure all release groups match at least one project
3 participants
@xiongemi @JamesHenry @leosvelperez