Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misc): set hidden: true for all init generators #29833

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Jan 31, 2025

This PR ensures that our init generators are hidden, such that they don't appear in Nx Console when running generators, for example.

The init generator is meant to be used when running other generators, like app or lib, and should not be run directly.

Current Behavior

Init is not hidden

Expected Behavior

Init is hidden

Related Issue(s)

Fixes #

@jaysoo jaysoo requested review from FrozenPandaz, xiongemi and a team as code owners January 31, 2025 19:23
Copy link

vercel bot commented Jan 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Jan 31, 2025 7:41pm

Copy link

nx-cloud bot commented Jan 31, 2025

View your CI Pipeline Execution ↗ for commit 07f042b.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 28m 48s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 17s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base= --he... ✅ Succeeded 6s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 5s View ↗
nx documentation ✅ Succeeded 1m 39s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-31 20:07:46 UTC

@FrozenPandaz FrozenPandaz merged commit 77ad299 into master Feb 3, 2025
12 checks passed
@FrozenPandaz FrozenPandaz deleted the fix/hide-init branch February 3, 2025 15:40
FrozenPandaz pushed a commit that referenced this pull request Feb 6, 2025
This PR ensures that our init generators are hidden, such that they
don't appear in Nx Console when running generators, for example.

The init generator is meant to be used when running other generators,
like app or lib, and should not be run directly.

## Current Behavior
Init is not hidden

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->
Init is hidden
## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #

(cherry picked from commit 77ad299)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants