[#811] Search Feature On Some ACA Pages Is Not Working #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… I believe the search function is tied to one of the js files. Might need to write some JS.
…bles file, replaced var with let in other script tags, currently figuring out how to upgrade bootstrap.
…HIRS in another issue. Figured out where the search issue lies. Need to figure out how to search on columns on the server side.
… chain management pages. Need to clean up a bit and it should be PR ready manana.
… pages into their own controller class due to the massive size of the main cert page controller class and because the changes i want to implement require it.
…ving the older datatables table, I was looking at a PR of 280+ files changed. I put it back in its place, i am still referencing the new library and i will create a new issue that addresses removing old libraries and replacing them with new ones.
…controllers. Search feature works fine. Found bug that exists in main branch as well (will fix it in here). Will now need to worry about searching just on individual comments, adding more javadocs/comments, and lastly fixing error/info messages display.
…ollers, fixed error/info messages display, fixed build issue and fixed checksytle issues. New code works like a charm. Need to fix platform cert bug found on main and need to finish implementing the new search feature for all the other aca pages/ individual table columns.
…ry report. Added a new service. Will start moving bulky functions in the controller to the summary service class.
…s. WOrking on doing the same for the RIMs and RIM DB. Validation summary ug found and created an issue for said bug. Create the pipeline for doing a global search for validation summaires - will now need to figure out how to fix the issues for that page to get it to work 80% done.
…rims, and pcr values. The table doesnt accuratle refelect how many items have been filtered, validation summaries still need work for the global search feature to work, need to also work on searching on just on indiviudal columns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test Instructions
Issues this PR addresses:
Closes #811