dbft: simplify PreBlock constructor

Move hasAllTransactions check from PreBlock constructor to onPreCommit callback. The rest of CreatePreBlock usages already have this check. Signed-off-by: Anna Shaleva <[email protected]>
nspcc-dev · Sep 3, 2024 · a6c5026 · a6c5026
1 parent a70ec44
commit a6c5026
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/context.go b/context.go
@@ -344,9 +344,6 @@ func (c *Context[H]) CreatePreBlock() PreBlock[H] {
 		if c.preBlock = c.MakePreHeader(); c.preBlock == nil {
 			return nil
 		}
-		if !c.hasAllTransactions() {
-			return nil
-		}
 
 		txx := make([]Transaction[H], len(c.TransactionHashes))
 

diff --git a/dbft.go b/dbft.go
@@ -544,6 +544,9 @@ func (d *DBFT[H]) onPreCommit(msg ConsensusPayload[H]) {
 		d.Logger.Info("received PreCommit", zap.Uint("validator", uint(msg.ValidatorIndex())))
 		d.extendTimer(4)
 
+		if !d.hasAllTransactions() {
+			return
+		}
 		preBlock := d.CreatePreBlock()
 		if preBlock != nil {
 			pub := d.Validators[msg.ValidatorIndex()]