Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider moving dBFT payload interfaces to dbft #90

Closed
AnnaShaleva opened this issue Feb 9, 2024 · 0 comments · Fixed by #97
Closed

Consider moving dBFT payload interfaces to dbft #90

AnnaShaleva opened this issue Feb 9, 2024 · 0 comments · Fixed by #97
Labels
enhancement Improving existing functionality I3 Minimal impact S3 Minimally significant U4 Nothing urgent
Milestone
v0.2.0

Comments

@AnnaShaleva
Copy link
Member

Currently generic dBFT payload interfaces are located at the dbft/payload folder (ChangeView, PrepareRequest and etc.). We need to consider moving them to dbft. Ref. #89 (comment)
@AnnaShaleva AnnaShaleva added enhancement Improving existing functionality U4 Nothing urgent S3 Minimally significant I3 Minimal impact labels Feb 9, 2024
@AnnaShaleva AnnaShaleva mentioned this issue Feb 9, 2024
Merged
@roman-khimov roman-khimov mentioned this issue Feb 9, 2024
Closed
@AnnaShaleva AnnaShaleva added this to the v0.2.0 milestone Feb 13, 2024
@AnnaShaleva AnnaShaleva mentioned this issue Feb 13, 2024
Merged
AnnaShaleva added a commit that referenced this issue Feb 19, 2024
@AnnaShaleva
dbft: move payloads/block/tx/crypto interfaces to dbft package
5a8dfed 
Close #90.

Signed-off-by: Anna Shaleva <[email protected]>
@AnnaShaleva AnnaShaleva mentioned this issue Feb 19, 2024
Merged
3 tasks
AnnaShaleva added a commit that referenced this issue Mar 1, 2024
@AnnaShaleva
dbft: move payloads/block/tx/crypto interfaces to dbft package
5f08ff0 
Close #90.

Signed-off-by: Anna Shaleva <[email protected]>
AnnaShaleva added a commit that referenced this issue Mar 4, 2024
@AnnaShaleva
dbft: move payloads/block/tx/crypto interfaces to dbft package
854105f 
Close #90.

Signed-off-by: Anna Shaleva <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improving existing functionality I3 Minimal impact S3 Minimally significant U4 Nothing urgent
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging a pull request may close this issue.

dbft: move payloads/block/tx/crypto interfaces to dbft package nspcc-dev/dbft
1 participant
@AnnaShaleva