-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dbft: move payloads/block/tx/crypto interfaces to dbft package #97
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #97 +/- ##
==========================================
- Coverage 73.22% 72.30% -0.93%
==========================================
Files 24 25 +1
Lines 1393 1390 -3
==========================================
- Hits 1020 1005 -15
- Misses 305 318 +13
+ Partials 68 67 -1 ☔ View full report in Codecov by Sentry. |
@roman-khimov, I need some initial assessment of the resulting packages structure from your side. If the direction is OK, then I'll update the documentation. The resulting built binary is smaller than the one got from master:
I'm not sure how to deal with |
It looks OK except for some new exports. I'd then want to simplify payload interfaces (getters/setters suck), but that can wait. |
Close #90. Signed-off-by: Anna Shaleva <[email protected]>
f5818b9
to
2640fae
Compare
To avoid cyclic dependency during tests and completely untie dBFT from non-generic payloads implementation. Signed-off-by: Anna Shaleva <[email protected]>
Noone needs them, they are used only for tests and as examples. Signed-off-by: Anna Shaleva <[email protected]>
…ture Signed-off-by: Anna Shaleva <[email protected]>
Signed-off-by: Anna Shaleva <[email protected]>
We may do this in #84. |
Two parts of dBFT structure refactoring: close #90, close #91.
TODO: