internal: drop rfc6979 dependency #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nothing bad about it, but we can easily live without it as well, it's not a production code. Less things to care about here. Signed-off-by: Roman Khimov <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #101 +/- ##
==========================================
- Coverage 63.89% 63.80% -0.09%
==========================================
Files 26 26
Lines 1573 1575 +2
==========================================
Hits 1005 1005
- Misses 501 502 +1
- Partials 67 68 +1 ☔ View full report in Codecov by Sentry. |
Along with deprecated RIPEMD160. It doesn't matter how we create hashes in test code. Signed-off-by: Roman Khimov <[email protected]>
AnnaShaleva
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing bad about it, but we can easily live without it as well, it's not a production code. Less things to care about here.