Final user-facing interface improvements #107
Merged
Commits on Mar 21, 2024
-
config: add named arguments to configurable callbacks
It gives a hint to the user what arguments are passed to these callbacks since it's not always clear from type. Signed-off-by: Anna Shaleva <[email protected]>
-
dbft: return an error from constructor if config is invalid
It's not user-friendly to retyrn an empty instance without any error. Signed-off-by: Anna Shaleva <[email protected]>
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.