Simplify library interfaces a bit #114
Merged
Commits on Apr 24, 2024
-
identity: remove useless interfaces from dbft.PublicKey
dbft requires PublicKey to be equatable, no marshaller or verification should be used by dbft library. Also, it's not very user-friendly to perform public key comparison via marshalling, and thus, this code is refactored. Signed-off-by: Anna Shaleva <[email protected]>
-
config: simplify key pair related config setters
Either WithKeyPair or WithGetKeyPair should be kept. The latter is more general, thus I'm keeping it and removing the first setter. Signed-off-by: Anna Shaleva <[email protected]>
-
identity: simplify PublicKey interface
dbft package itself doesn't need anything from PublicKey. It's the user who is responsible for public keys comparison and WithGetKeyPair callback implementation. Signed-off-by: Anna Shaleva <[email protected]>
-
CHANGELOG: add a note about PublicKey and config interfaces simplific…
…ation Signed-off-by: Anna Shaleva <[email protected]>
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.