Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbft: replace boring cycle with fancy condition #123

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Conversation

roman-khimov
Copy link
Member

It's obviously better this way.

It's obviously better this way.

Signed-off-by: Roman Khimov <[email protected]>
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.38%. Comparing base (befa250) to head (ffa8c1f).
Report is 16 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #123      +/-   ##
==========================================
+ Coverage   59.35%   59.38%   +0.03%     
==========================================
  Files          32       32              
  Lines        1823     1817       -6     
==========================================
- Hits         1082     1079       -3     
+ Misses        661      659       -2     
+ Partials       80       79       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

AnnaShaleva
AnnaShaleva previously approved these changes Aug 15, 2024
Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, changelog is not updated, but the job is not even started, need to check if it works.

Copy link

@AliceInHunterland AliceInHunterland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

magic

@AnnaShaleva AnnaShaleva dismissed their stale review August 15, 2024 08:10

Need to update CHANGELOG.

@roman-khimov
Copy link
Member Author

changelog is not updated

This doesn't change the behavior in any way.

@AnnaShaleva AnnaShaleva merged commit dfeaa39 into master Aug 15, 2024
12 checks passed
@AnnaShaleva AnnaShaleva deleted the code-golf branch August 15, 2024 09:18
@roman-khimov roman-khimov added enhancement Improving existing functionality U4 Nothing urgent S4 Routine I4 No visible changes labels Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving existing functionality I4 No visible changes S4 Routine U4 Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants