Org-wide linter #131
Merged
Org-wide linter #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roman Khimov <[email protected]>
dbft.go:703:18 durationcheck Multiplication of durations: `count * d.SecondsPerBlock` Signed-off-by: Roman Khimov <[email protected]>
internal/consensus/amev_block.go:39:44 misspell `transations` is a misspelling of `transitions` Signed-off-by: Roman Khimov <[email protected]>
helpers.go:50:2 exhaustive missing cases in switch of type dbft.MessageType: dbft.RecoveryRequestType, dbft.RecoveryMessageType internal/consensus/recovery_message.go:39:2 exhaustive missing cases in switch of type dbft.MessageType: dbft.RecoveryRequestType, dbft.RecoveryMessageType Signed-off-by: Roman Khimov <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #131 +/- ##
==========================================
- Coverage 59.25% 59.19% -0.07%
==========================================
Files 32 32
Lines 1831 1833 +2
==========================================
Hits 1085 1085
- Misses 665 667 +2
Partials 81 81 ☔ View full report in Codecov by Sentry. |
AnnaShaleva
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.