Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check: extend ProcessBlock callback with error handler #134

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AnnaShaleva
Copy link
Member

For anti-MEV extension it's possible that some commits carry invalid share which is impossible to check at the commit verification level. In this case node should collect some more commits.

The general idea is similar to PreBlock processing behaviour. Draft until it's properly tested on NeoX side.

For anti-MEV extension it's possible that some commits carry invalid
share which is impossible to check at the commit verification level.
In this case node should collect some more commits.

Signed-off-by: Anna Shaleva <[email protected]>
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 30.76923% with 9 lines in your changes missing coverage. Please review.

Project coverage is 58.48%. Comparing base (82ad778) to head (2cd731a).

Files with missing lines Patch % Lines
check.go 33.33% 5 Missing and 1 partial ⚠️
internal/simulation/main.go 0.00% 2 Missing ⚠️
config.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
- Coverage   58.67%   58.48%   -0.19%     
==========================================
  Files          32       32              
  Lines        2231     2238       +7     
==========================================
  Hits         1309     1309              
- Misses        841      847       +6     
- Partials       81       82       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant