Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: add Hash/Address generic parameters to dBFT #94

Merged
merged 3 commits into from
Feb 13, 2024
Merged

*: add Hash/Address generic parameters to dBFT #94

merged 3 commits into from
Feb 13, 2024

Commits on Feb 13, 2024

  1. *: use generic hashes implementation for DBFT 

    A part of #2. Use generics instead of util.Uint160 and util.Uint256
types for DBFT and related components. Keep util.Uint160 and util.Uint256
only for specific DBFT implementation in testing code.

The following regressions/behaviour changes were made to properly
apply generics:
1. `dbft.Option` alias is removed since type parameters can't be defined
   on aliases (generic type aliases are prohibited). Ref.
   golang/go#46477.
2. Default dBFT configuration is reduced: all payload-specific defaults
   are removed, as described in #91.
   It is done because default dBFT configuration should not depend on any
   implementation-specific hash type.
3. DBFT configuration validation check is extended wrt point 2.
4. The check if generic `dbft.DBFT` type implements generic `dbft.Service`
   interface is removed since such check should be performed on particular
   (non-generic) DBFT implementation.

Signed-off-by: Anna Shaleva <[email protected]>
    @AnnaShaleva
    AnnaShaleva committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    2d3a276 View commit details
    Browse the repository at this point in the history

  2. crypto, *: introduce own Hash/Address implementation 

    A part of #2. Use custom Hash/Address implementation, get rid of
util.Uint256/util.Uint160 NeoGo dependency.

Signed-off-by: Anna Shaleva <[email protected]>
    @AnnaShaleva
    AnnaShaleva committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    c43e88f View commit details
    Browse the repository at this point in the history

  3. go.mod: remove NeoGo dependency 

    A part of #2, not needed anymore.

Signed-off-by: Anna Shaleva <[email protected]>
    @AnnaShaleva
    AnnaShaleva committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    87f247c View commit details
    Browse the repository at this point in the history