Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github: use minimum required Go version from go.mod file #99

Merged
merged 3 commits into from
Feb 27, 2024

Conversation

AnnaShaleva
Copy link
Member

For linter job only. Port
nspcc-dev/neofs-contract@e0ec4d2.

@AnnaShaleva AnnaShaleva marked this pull request as ready for review February 27, 2024 08:47
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.22%. Comparing base (4d158d9) to head (cd438c5).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #99   +/-   ##
=======================================
  Coverage   73.22%   73.22%           
=======================================
  Files          24       24           
  Lines        1393     1393           
=======================================
  Hits         1020     1020           
  Misses        305      305           
  Partials       68       68           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AnnaShaleva AnnaShaleva added the go Go language related label Feb 27, 2024
@AnnaShaleva AnnaShaleva added this to the v0.2.0 milestone Feb 27, 2024
Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32f2edc is a part of 9a918d4 to me, otherwise action is broken in-between.

Otherwise setup-go action won't work with go-version-file. Ref.
actions/setup-go#340.

Signed-off-by: Anna Shaleva <[email protected]>
@AnnaShaleva
Copy link
Member Author

AnnaShaleva commented Feb 27, 2024

32f2edc is a part of 9a918d4 to me, otherwise action is broken in-between.

Sure, there was a rebase conflict when I realized it, so I just got lazy to solve it. Fixed now.

@roman-khimov roman-khimov merged commit e4fad43 into master Feb 27, 2024
8 checks passed
@roman-khimov roman-khimov deleted the go-ver branch February 27, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Go language related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants