mpt: refactor lcp to be possible to use range

It took some time to understand why changing a regular `for` to a `range` one leads to behavior changes; let it be more clear and explicit. Also, a correct code is always better than a correct code with `nolint`. Signed-off-by: Pavel Karpy <[email protected]>
nspcc-dev · Sep 4, 2024 · 320d33b · 320d33b
1 parent e3700ea
commit 320d33b
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/pkg/core/mpt/helpers.go b/pkg/core/mpt/helpers.go
@@ -13,17 +13,13 @@ func lcp(a, b []byte) []byte {
 		return lcp(b, a)
 	}
 
-	var i int
-	//nolint:intrange // if slices are the same (or one is a prefix for another
-	// one), `range` loops does not assign the latest index to the `i` var, and
-	// the func loses the latest element
-	for i = 0; i < len(b); i++ {
+	for i := range b {
 		if a[i] != b[i] {
-			break
+			return b[:i]
 		}
 	}
 
-	return a[:i]
+	return b
 }
 
 func lcpMany(kv []keyValue) []byte {