Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: add Rules signer scope to request parameters #2384

Merged
merged 1 commit into from
Mar 3, 2022
Merged

Conversation

AnnaShaleva
Copy link
Member

Port a part of neo-project/neo-modules#694. Waiting for the reference PR to settle.

@codecov
Copy link

codecov bot commented Mar 3, 2022

Codecov Report

Merging #2384 (3d5b1d8) into master (992d74d) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2384      +/-   ##
==========================================
- Coverage   84.97%   84.96%   -0.01%     
==========================================
  Files         290      290              
  Lines       36050    36052       +2     
==========================================
+ Hits        30632    30633       +1     
- Misses       4119     4120       +1     
  Partials     1299     1299              
Impacted Files Coverage Δ
pkg/core/blockchain.go 82.88% <100.00%> (ø)
pkg/core/dao/dao.go 83.13% <100.00%> (ø)
pkg/rpc/request/param.go 87.34% <100.00%> (+0.07%) ⬆️
pkg/network/server.go 74.08% <0.00%> (-0.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff60571...3d5b1d8. Read the comment docs.

Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be done irrespective of neo-project/neo-modules#694 outcome.

@roman-khimov roman-khimov merged commit 3db8dff into master Mar 3, 2022
@roman-khimov roman-khimov deleted the rpc/rules branch March 3, 2022 11:46
@roman-khimov roman-khimov added this to the v0.98.2 milestone Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants