compiler: allow to use multiple returns in inlined functions #2594

fyrchik · 2022-07-12T08:50:36Z

codecov · 2022-07-12T09:02:11Z

Codecov Report

Merging #2594 (17329ee) into master (125c280) will decrease coverage by 0.00%.
The diff coverage is 96.07%.

@@            Coverage Diff             @@
##           master    #2594      +/-   ##
==========================================
- Coverage   84.58%   84.58%   -0.01%     
==========================================
  Files         298      298              
  Lines       37836    37841       +5     
==========================================
+ Hits        32003    32006       +3     
- Misses       4424     4425       +1     
- Partials     1409     1410       +1

Impacted Files	Coverage Δ
pkg/compiler/func_scope.go	`100.00% <ø> (ø)`
pkg/compiler/codegen.go	`92.36% <95.23%> (-0.11%)`	⬇️
pkg/compiler/inline.go	`96.75% <100.00%> (+0.07%)`	⬆️
pkg/core/transaction/transaction.go	`85.18% <0.00%> (-1.49%)`	⬇️
pkg/network/server.go	`74.09% <0.00%> (+0.09%)`	⬆️
pkg/network/compress.go	`76.00% <0.00%> (+12.00%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9414538...17329ee. Read the comment docs.

pkg/compiler/byte_conversion_test.go

pkg/compiler/inline_test.go

pkg/compiler/codegen.go

Signed-off-by: Evgeniy Stratonikov <[email protected]>

First replace parts to be removed with NOPs, then actually remove. Signed-off-by: Evgeniy Stratonikov <[email protected]>

pkg/compiler/codegen.go

In case there are no returns in the inlined function, jumps point to the next instruction and can be omitted. This optimization can be extended to handle other cases, here we just make sure that already existing code stays the same. Signed-off-by: Evgeniy Stratonikov <[email protected]>

AnnaShaleva approved these changes Jul 12, 2022

View reviewed changes

pkg/compiler/byte_conversion_test.go Outdated Show resolved Hide resolved

roman-khimov reviewed Jul 12, 2022

View reviewed changes

pkg/compiler/byte_conversion_test.go Outdated Show resolved Hide resolved

pkg/compiler/inline_test.go Outdated Show resolved Hide resolved

pkg/compiler/inline_test.go Outdated Show resolved Hide resolved

pkg/compiler/codegen.go Outdated Show resolved Hide resolved

fyrchik added 2 commits July 12, 2022 12:43

compiler: allow to use conditional returns in inlined functions

ce24451

Signed-off-by: Evgeniy Stratonikov <[email protected]>

compiler: reduce instructions in 2 stages

05efc57

First replace parts to be removed with NOPs, then actually remove. Signed-off-by: Evgeniy Stratonikov <[email protected]>

roman-khimov reviewed Jul 12, 2022

View reviewed changes

pkg/compiler/codegen.go Outdated Show resolved Hide resolved

roman-khimov approved these changes Jul 12, 2022

View reviewed changes

AnnaShaleva approved these changes Jul 12, 2022

View reviewed changes

fyrchik mentioned this pull request Jul 12, 2022

Support more instruction-level optimizations #2596

Open

roman-khimov merged commit 71b721c into master Jul 12, 2022

roman-khimov deleted the compiler-inline-return branch July 12, 2022 18:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

compiler: allow to use multiple returns in inlined functions #2594

compiler: allow to use multiple returns in inlined functions #2594

fyrchik commented Jul 12, 2022

codecov bot commented Jul 12, 2022 •

edited

Loading

compiler: allow to use multiple returns in inlined functions #2594

compiler: allow to use multiple returns in inlined functions #2594

Conversation

fyrchik commented Jul 12, 2022

codecov bot commented Jul 12, 2022 • edited Loading

Codecov Report

codecov bot commented Jul 12, 2022 •

edited

Loading