-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
examples: NNS update, part 5 #2693
Draft
AnnaShaleva
wants to merge
16
commits into
master
Choose a base branch
from
nns-upd-3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply new NNS rules.
Except for the CNAME records. Port nspcc-dev/neofs-contract@6ea4573 and nspcc-dev/neofs-contract@f4762c1.
Codecov Report
@@ Coverage Diff @@
## master #2693 +/- ##
==========================================
+ Coverage 85.23% 85.43% +0.20%
==========================================
Files 322 322
Lines 39398 39680 +282
==========================================
+ Hits 33580 33900 +320
+ Misses 4479 4455 -24
+ Partials 1339 1325 -14
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
If conflicting records '*.domain' are present on new domain registration, then `isAvailable` should return false for this domain. Ref. nspcc-dev/neofs-contract@f25296b.
AnnaShaleva
force-pushed
the
nns-upd-3
branch
from
September 16, 2022 08:21
1e24838
to
14c9858
Compare
AnnaShaleva
changed the title
examples: NNS update, part 3
examples: NNS update, part 5
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2687.