Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: port changes from C# NNS contract #2694

Draft
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

AnnaShaleva
Copy link
Member

This PR includes changes implemented into C# NNS version (https://github.com/neo-project/non-native-contracts/blob/master/src/NameService/NameService.cs):

  1. Domain registration price is dependant on domain name length. By default, short (<5 chars) domain names are available for registration only for committee.
  2. Renew overload is added that accepts expiration period as an argument. This change is backwords-compatible.
  3. SetAdmin and Renew events are added.

Apply new NNS rules.
If conflicting records '*.domain' are present on new domain
registration, then `isAvailable` should return false for this
domain. Ref.
nspcc-dev/neofs-contract@f25296b.
@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Merging #2694 (abd332f) into master (20224cb) will increase coverage by 0.27%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2694      +/-   ##
==========================================
+ Coverage   85.23%   85.50%   +0.27%     
==========================================
  Files         322      322              
  Lines       39398    39680     +282     
==========================================
+ Hits        33580    33928     +348     
+ Misses       4479     4423      -56     
+ Partials     1339     1329      -10     
Impacted Files Coverage Δ
pkg/network/message.go 94.02% <0.00%> (-1.50%) ⬇️
pkg/services/notary/notary.go 82.08% <0.00%> (-0.55%) ⬇️
pkg/services/stateroot/network.go 76.71% <0.00%> (-0.32%) ⬇️
pkg/services/oracle/response.go 84.80% <0.00%> (-0.24%) ⬇️
pkg/network/server.go 73.08% <0.00%> (-0.17%) ⬇️
pkg/neorpc/errors.go 69.69% <0.00%> (ø)
pkg/rpcclient/nep11.go 0.00% <0.00%> (ø)
pkg/consensus/crypto.go 100.00% <0.00%> (ø)
pkg/rpcclient/policy.go 65.38% <0.00%> (ø)
pkg/util/slice/array.go 100.00% <0.00%> (ø)
... and 45 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant