rpcsrv: support Map parameter in invokefunction RPC handler
#3329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnnaShaleva
added
bug
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3329 +/- ##
==========================================
- Coverage 84.94% 84.87% -0.08%
==========================================
Files 328 328
Lines 44789 44825 +36
==========================================
- Hits 38048 38045 -3
- Misses 5229 5267 +38
- Partials 1512 1513 +1 ☔ View full report in Codecov by Sentry. |
roman-khimov
requested changes
Feb 27, 2024
AnnaShaleva
force-pushed
the
support-rpc-maps
branch
from
6de3e47
to
209fa41
Compare
We have smartcontract.ParameterPair structure that can be properly marshalled and passed to RPC server as an element of smartcontract.Map structure. However, RPC server can't unmarshal map values properly without this change. This change is compatible with C# node. Signed-off-by: Anna Shaleva <[email protected]>
AnnaShaleva
force-pushed
the
support-rpc-maps
branch
from
209fa41
to
132531f
Compare
roman-khimov
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have smartcontract.ParameterPair structure that can be properly marshalled and passed to RPC server as an element of smartcontract.Map structure. However, RPC server can't unmarshal map values properly without this change.
This change is compatible with C# node.