Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpcsrv: fix RPC error codes proposal compatibility #3360

Merged
merged 2 commits into from
Mar 18, 2024
Merged

rpcsrv: fix RPC error codes proposal compatibility #3360

merged 2 commits into from
Mar 18, 2024

Commits on Mar 18, 2024

  1. rpcsrv: generate randome nonce for RPC server test transactions 

    Avoid mempool conflicts in tests.

Signed-off-by: Anna Shaleva <[email protected]>
    @AnnaShaleva
    AnnaShaleva committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    335550f View commit details
    Browse the repository at this point in the history

  2. rpcsrv: fix RPC error codes proposal compatibility 

    mempool.ErrInsufficientFunds is used when sender doesn't have enough
balance to pay the submitted transaction fees (-511 code according to
neo-project/proposals#156). mempool.ErrConflict is
used when sender is not able to pay the overall transactions fee sum in
the pool (generic -500 error according to the proposal).

This bugfix is kind of breaking change for those users who relied on the
old -511 code previously returning "insufficient funds" error.

Signed-off-by: Anna Shaleva <[email protected]>
    @AnnaShaleva
    AnnaShaleva committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    82e52c4 View commit details
    Browse the repository at this point in the history