Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpcsrv: fix insufficient funds use #3361

Merged
merged 1 commit into from
Mar 18, 2024
Merged

rpcsrv: fix insufficient funds use #3361

merged 1 commit into from
Mar 18, 2024

Conversation

roman-khimov
Copy link
Member

This is not the way intended in neo-project/proposals#156. -511 covers both cases because users hardly can distinguish one from another, it's just that our mempool implementation has error codes for both..

Refs. #3360.

This is not the way intended in neo-project/proposals#156.
-511 covers _both_ cases because users hardly can distinguish one from another,
it's just that our mempool implementation has error codes for both..

Signed-off-by: Roman Khimov <[email protected]>
Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, then no changes in C# repo are required.

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.67%. Comparing base (445ab97) to head (27f79b8).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3361   +/-   ##
=======================================
  Coverage   84.66%   84.67%           
=======================================
  Files         331      331           
  Lines       44935    44935           
=======================================
+ Hits        38045    38048    +3     
+ Misses       5376     5374    -2     
+ Partials     1514     1513    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roman-khimov roman-khimov merged commit 7e12cc1 into master Mar 18, 2024
19 of 20 checks passed
@roman-khimov roman-khimov deleted the fix-rpc-511 branch March 18, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants